Integrate big endian hashes, integrate them into the bitcoind-rpc pro… #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ject
This integrates the
BE(big endian) hash type.We now have big endian versions of hash digests such as
DoubleSha256DigestBE. Due to how satoshis built the bitcoin protocol hashes are little endian at the protocol level, but big endian at the rpc level. This is a source of confusion for developers we make an explicit type for the big endian hash digests.This is needed for the node project, as we will be dealing with a lot of endianness issues with databases. I want the endianess to be encoded explicitly in the type.