Skip to content

BIP8: Make signalling during LOCKED_IN recommended rather than mandatory - #1020

Merged
luke-jr merged 1 commit into
bitcoin:masterfrom
ajtowns:202010-bip8-lockedin-rec
Feb 2, 2021
Merged

luke-jr merged 1 commit into
bitcoin:masterfrom
ajtowns:202010-bip8-lockedin-rec

Conversation

@ajtowns

@ajtowns ajtowns commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

With the addition of the MUST_SIGNAL phase, signalling during LOCKED_IN is no longer needed for activation coordination, so drop it.

@ajtowns

ajtowns commented Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

At present, the only time anyone has to potentially immediately update their consensus rules is if the last block in a STARTED period pushes signalling over the threshold, at which point the next block has to immediately signal or is invalid. There's grace periods for everything else -- enforcing the rules has the 2016 blocks of LOCKED_IN between knowing it's coming and it actually happening; and the first block of MUST_SIGNAL (hopefully) has a few months of grace between everyone deciding to set lockinontimeout=true and timeoutheight actually arriving.

@luke-jr luke-jr added the Proposed BIP modification PR by non-owner to update BIP content label Oct 19, 2020

@jonasnick jonasnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
this seems to be a remnant from before MUST_SIGNAL and there's no reason to not have a grace period

@michaelfolkson

Copy link
Copy Markdown
Contributor

ACK. LOCKED_IN is an end state on the happy path. Once we reach this state there are no requirements in terms of signaling. Continued signaling is a nice to have but has no impact on the path taken or the end result.

@benthecarman

Copy link
Copy Markdown
Contributor

ACK this makes more sense

@luke-jr
luke-jr merged commit 79cd91e into bitcoin:master Feb 2, 2021
@achow101

achow101 commented Feb 2, 2021

Copy link
Copy Markdown
Member

ACK 9a119ce

@ProofOfKeags ProofOfKeags left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lucasmoten

Copy link
Copy Markdown

ACK

3 similar comments
@AbelLykens

Copy link
Copy Markdown

ACK

@wangchun

wangchun commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

ACK

@AlejandroDeLaTorre

Copy link
Copy Markdown

ACK

@setpill

setpill commented Feb 2, 2021

Copy link
Copy Markdown

ACK 9a119ce

@darosior darosior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a119ce

@kaloudis

kaloudis commented Feb 2, 2021

Copy link
Copy Markdown

ACK 9a119ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Development

Successfully merging this pull request may close these issues.