Skip to content

BIP8: Make signalling during LOCKED_IN recommended rather than mandatory #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

ajtowns
Copy link
Contributor

@ajtowns ajtowns commented Oct 17, 2020

With the addition of the MUST_SIGNAL phase, signalling during LOCKED_IN is no longer needed for activation coordination, so drop it.

@ajtowns
Copy link
Contributor Author

ajtowns commented Oct 17, 2020

At present, the only time anyone has to potentially immediately update their consensus rules is if the last block in a STARTED period pushes signalling over the threshold, at which point the next block has to immediately signal or is invalid. There's grace periods for everything else -- enforcing the rules has the 2016 blocks of LOCKED_IN between knowing it's coming and it actually happening; and the first block of MUST_SIGNAL (hopefully) has a few months of grace between everyone deciding to set lockinontimeout=true and timeoutheight actually arriving.

Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
this seems to be a remnant from before MUST_SIGNAL and there's no reason to not have a grace period

@michaelfolkson
Copy link

ACK. LOCKED_IN is an end state on the happy path. Once we reach this state there are no requirements in terms of signaling. Continued signaling is a nice to have but has no impact on the path taken or the end result.

@benthecarman
Copy link
Contributor

ACK this makes more sense

@luke-jr luke-jr merged commit 79cd91e into bitcoin:master Feb 2, 2021
@achow101
Copy link
Member

achow101 commented Feb 2, 2021

ACK 9a119ce

Copy link
Contributor

@ProofOfKeags ProofOfKeags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lucasmoten
Copy link

ACK

3 similar comments
@AbelLykens
Copy link

ACK

@wangchun
Copy link
Contributor

wangchun commented Feb 2, 2021

ACK

@AlejandroDeLaTorre
Copy link

ACK

@setpill
Copy link

setpill commented Feb 2, 2021

ACK 9a119ce

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a119ce

@kaloudis
Copy link

kaloudis commented Feb 2, 2021

ACK 9a119ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.