Skip to content

BIP32: Modified test vectors for hardened derivation with leading zeros - #1030

Merged
kallewoof merged 1 commit into
bitcoin:masterfrom
silencer-Tsai:test-vectors
Jun 12, 2021
Merged

BIP32: Modified test vectors for hardened derivation with leading zeros#1030
kallewoof merged 1 commit into
bitcoin:masterfrom
silencer-Tsai:test-vectors

Conversation

@silencer-Tsai

@silencer-Tsai silencer-Tsai commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

As mentioned in bitpay/bitcore-lib#47, iancoleman/bip39#58 and btcsuite/btcutil#172, the private key with leading zeros(i.e. less than 32 bytes) should be padded to 32 bytes when we derive a hardened child private key from a private key.

Unfortunately, the original test vector 3 is not suitable for this case since both keys are 32 bytes.

In the new test vectors, the key m/0H is 31 bytes.

btcsuite/btcutil just fix the bug. See btcsuite/btcutil#182.

@schildbach

schildbach commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

I think old test vectors should not be deleted. They are needed as regression tests.

FYI bitcoinj passes the new test vectors without changes.

dgpv added a commit to Simplexum/python-bitcointx that referenced this pull request Nov 4, 2020
@dgpv
Test vectors for BIP32 derivation with leading zeros (to sync with BIP)
def047e 
The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)
@dgpv dgpv mentioned this pull request Nov 4, 2020
Closed
@silencer-Tsai

silencer-Tsai commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@schildbach
Agree. I have brought it back already.

dgpv added a commit to Simplexum/python-bitcointx that referenced this pull request Nov 4, 2020
@dgpv
Test vectors for BIP32 derivation with leading zeros (to sync with BIP)
4084cc1 
The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)
@afk11

afk11 commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

Thanks for sharing the test fixture!

@junderw

junderw commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

So existing Test 3 is for testing if the initial seed -> master generation step works with a 0x00 leading private key part.
Newly added Test 4 tests for the existing extended key -> child hardened key step for working with 0x00 leading private key part.

This makes sense since most implementations perform the HMACs for seed -> master and node -> child in separate places in the code, so it makes sense to test both.

LGTM

dgpv added a commit to Simplexum/python-bitcointx that referenced this pull request Dec 4, 2020
@dgpv
Test vectors for BIP32 derivation with leading zeros (to sync with BIP)
b41a484 
The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)
@luke-jr
luke-jr requested a review from sipa February 3, 2021 22:03
@luke-jr luke-jr added the Proposed BIP modification PR by non-owner to update BIP content label Feb 3, 2021
SomberNight added a commit to spesmilo/electrum that referenced this pull request Feb 18, 2021
@SomberNight
bip32: add new test vectors from BIP
b856336 
also yet-to-be-merged test from bitcoin/bips#1030
@Giszmo

Giszmo commented May 20, 2021

Copy link
Copy Markdown
Contributor

What exactly is the hold-up here? LGTM!

@kristapsk kristapsk mentioned this pull request May 25, 2021
Merged
kristapsk added a commit to JoinMarket-Org/joinmarket-clientserver that referenced this pull request May 25, 2021
@kristapsk
Merge #880: Additional BIP32 test vector for hardened derivation with…
64f3a88 
… leading zeros

516e46a Additional BIP32 test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

Top commit has no ACKs.

Tree-SHA512: 7c0d6f988391297ba83fbebb88f890e88d7458a963e58497714f7385a9982a0c5898d8bbfc3852f51ba3b433d419449bb1e1ca95c2832780628123f66a12e1ad
@kristapsk kristapsk mentioned this pull request May 28, 2021
Merged
@sipa

sipa commented May 28, 2021

Copy link
Copy Markdown
Member

ACK, verified that it actually exercises derivation from a private key with leading 0 byte.

@murchandamus

murchandamus commented May 28, 2021

Copy link
Copy Markdown
Member

ACK b0521f0

maflcko pushed a commit to bitcoin/bitcoin that referenced this pull request May 31, 2021
MarcoFalke
Merge #22095: test: Additional BIP32 test vector for hardened derivat…
8c6df2b 
…ion with leading zeros

91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

ACKs for top commit:
  practicalswift:
    cr ACK 91ef834
  sipa:
    ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.

Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
@maflcko

maflcko commented May 31, 2021

Copy link
Copy Markdown
Member

@luke-jr

@prusnak prusnak mentioned this pull request Jun 3, 2021
Merged
kristapsk
kristapsk approved these changes Jun 7, 2021
View reviewed changes

@kristapsk kristapsk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b0521f0

t-bast added a commit to ACINQ/bitcoin-lib that referenced this pull request Jun 9, 2021
@t-bast
Add hardened derivation leading zeros test
6ec1fa8 
A new test vectors was introduced in bitcoin/bips#1030
because some wallets didn't handle leading zeros correctly in hardened
derivation.

We already handled that case correctly, but didn't have a test vector for it.
@t-bast t-bast mentioned this pull request Jun 9, 2021
Merged
t-bast added a commit to ACINQ/bitcoin-kmp that referenced this pull request Jun 9, 2021
@t-bast
Add hardened derivation leading zeros test
d9bee88 
A new test vector was introduced in bitcoin/bips#1030
because some wallets didn't handle leading zeros correctly in
hardened derivation.

We already handled that case correctly, but didn't have a test vector for it.
@t-bast t-bast mentioned this pull request Jun 9, 2021
Merged
darosior added a commit to darosior/python-bip32 that referenced this pull request Jun 9, 2021
@darosior
tests: test vectors for leading zeros in private keys
fb75b61 
We were doing The Right Thing! See bitcoin/bips#1030

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
@maflcko

maflcko commented Jun 11, 2021

Copy link
Copy Markdown
Member

@kallewoof

@darosior

darosior commented Jun 11, 2021

Copy link
Copy Markdown
Member

ACK b0521f0 - tested in darosior/python-bip32#16

@kallewoof
kallewoof merged commit d2766d0 into bitcoin:master Jun 12, 2021
t-bast added a commit to ACINQ/bitcoin-lib that referenced this pull request Jun 14, 2021
@t-bast
Add hardened derivation leading zeros test (#54)
2be7607 
A new test vectors was introduced in bitcoin/bips#1030
because some wallets didn't handle leading zeros correctly in hardened
derivation.

We already handled that case correctly, but didn't have a test vector for it.
t-bast added a commit to ACINQ/bitcoin-kmp that referenced this pull request Jun 14, 2021
@t-bast
Add hardened derivation leading zeros test (#24)
224fcee 
A new test vector was introduced in bitcoin/bips#1030
because some wallets didn't handle leading zeros correctly in
hardened derivation.

We already handled that case correctly, but didn't have a test vector for it.
@benthecarman benthecarman mentioned this pull request Jun 22, 2021
Merged
@ChristopherA ChristopherA mentioned this pull request Jun 25, 2021
Open
dgpv added a commit to Simplexum/python-bitcointx that referenced this pull request Jul 15, 2021
@dgpv
Test vectors for BIP32 derivation with leading zeros (to sync with BIP)
33ededb 
The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)
PastaPastaPasta pushed a commit to knst/dash that referenced this pull request Dec 4, 2023
MarcoFalke @PastaPastaPasta
Merge bitcoin#22095: test: Additional BIP32 test vector for hardened …
f9c8136 
…derivation with leading zeros

91ef834 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

ACKs for top commit:
  practicalswift:
    cr ACK 91ef834
  sipa:
    ACK 91ef834. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.

Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
refactor-forge70 added a commit to refactor-forge70/bitcoin-lib that referenced this pull request Sep 28, 2025
@refactor-forge70
Add hardened derivation leading zeros test (#54)
ab4fac6 
A new test vectors was introduced in bitcoin/bips#1030
because some wallets didn't handle leading zeros correctly in hardened
derivation.

We already handled that case correctly, but didn't have a test vector for it.
tx-ravenxbsw3 added a commit to tx-ravenxbsw3/bitcoin-kmp that referenced this pull request Sep 29, 2025
@tx-ravenxbsw3
Add hardened derivation leading zeros test (#24)
79fd4f0 
A new test vector was introduced in bitcoin/bips#1030
because some wallets didn't handle leading zeros correctly in
hardened derivation.

We already handled that case correctly, but didn't have a test vector for it.
rawBit-io pushed a commit to rawBit-io/python-bitcointx that referenced this pull request Nov 6, 2025
@dgpv
Test vectors for BIP32 derivation with leading zeros (to sync with BIP)
a25ac70 
The code in bitcointx correctly handles this, but just to be in-sync
with the text of the BIP, use the new test vectors submitted in
bitcoin/bips#1030 (when it is merged)
Kino1994 pushed a commit to Kino1994/bitcoin-full-history that referenced this pull request Jun 28, 2026
MarcoFalke
Merge bitcoin/bitcoin#22095: test: Additional BIP32 test vector for h…
1e8e6d1 
…ardened derivation with leading zeros

bf99c24 Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

ACKs for top commit:
  practicalswift:
    cr ACK bf99c24
  sipa:
    ACK bf99c24. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.

Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
BigcoinBGC pushed a commit to BigcoinBGC/bigcoin that referenced this pull request Jun 30, 2026
MarcoFalke
Merge bitcoin/bitcoin#22095: test: Additional BIP32 test vector for h…
914410b 
…ardened derivation with leading zeros

03ead5d Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

ACKs for top commit:
  practicalswift:
    cr ACK 03ead5d
  sipa:
    ACK 03ead5d. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.

Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
ab4cus pushed a commit to ab4cus/e4Coin-core that referenced this pull request Jul 8, 2026
MarcoFalke @PastaPastaPasta
Merge bitcoin/bitcoin#22095: test: Additional BIP32 test vector for h…
2eb3fa2 
…ardened derivation with leading zeros

91ef8344d4de28b0a659401ef5fefee6c3d9f7ae Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

ACKs for top commit:
  practicalswift:
    cr ACK 91ef8344d4de28b0a659401ef5fefee6c3d9f7ae
  sipa:
    ACK 91ef8344d4de28b0a659401ef5fefee6c3d9f7ae. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.

Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
Kino1994 pushed a commit to Kino1994/bitcoin-full-history that referenced this pull request Aug 19, 2026
MarcoFalke
Merge bitcoin/bitcoin#22095: test: Additional BIP32 test vector for h…
19a895b 
…ardened derivation with leading zeros

91ef8344d4de28b0a659401ef5fefee6c3d9f7ae Additional test vector for hardened derivation with leading zeros (Kristaps Kaupe)

Pull request description:

  See [Inconsistent BIP32 Derivations](https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html) and bitcoin/bips#1030.

ACKs for top commit:
  practicalswift:
    cr ACK 91ef8344d4de28b0a659401ef5fefee6c3d9f7ae
  sipa:
    ACK 91ef8344d4de28b0a659401ef5fefee6c3d9f7ae. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.

Tree-SHA512: 0a3ae7aed15e4e08e9bec5db8de53c6c03ed3b3632f390394eea422597755173cbd2228ff0cfa57f5aae3df9d4cdf03a8ef4725cc8bce86ab7d9c82ab9d479ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sipa sipa Awaiting requested review from sipa
1 more reviewer
@kristapsk kristapsk kristapsk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sipa sipa

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.