bip 8: simplify MUST_SIGNAL check #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jonasnick @dr-orlovsky @luke-jr -- see also #1021 (comment) |
ajtowns
commented
Feb 4, 2021
ajtowns
force-pushed
the
202102-bip8-simplify-mustsignal-check
branch
from
3a9f7d9 to
63d2800
Compare
dr-orlovsky
approved these changes
Feb 5, 2021
jonasnick
reviewed
Feb 8, 2021
There was a problem hiding this comment.
ACK 63d2800
Sanity checked that there's no nasty off-by-one by adjusting my previous implementation according to this PR and running the same tests against it. The nonsignal == 0 was a neat optimization but fine to leave that up to the implementor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the validity check that at least threshold blocks are signalling during the MUST_SIGNAL phase for BIP 8.