Skip to content

BIP-345: withdraw#1848

Merged
murchandamus merged 1 commit into
bitcoin:masterfrom
jamesob:jamesob-25-05-withdraw-vault
May 8, 2025
Merged

BIP-345: withdraw#1848
murchandamus merged 1 commit into
bitcoin:masterfrom
jamesob:jamesob-25-05-withdraw-vault

Conversation

@jamesob

@jamesob jamesob commented May 6, 2025

Copy link
Copy Markdown
Contributor

This proposal has basically been replaced by #1793. See https://delvingbitcoin.org/t/withdrawing-op-vault-bip-345/1670 for rationale.

Comment thread bip-0345.mediawiki
Greg Sanders <gsanders87@gmail.com>
Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0345
Status: Draft
Status: Withdrawn

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README would need updating as well.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a diff like this

diff --git a/README.mediawiki b/README.mediawiki
index fe3be265..2ea96ed3 100644
--- a/README.mediawiki
+++ b/README.mediawiki
@@ -1127,13 +1127,13 @@ Standard
 | Final
-|-
+|- style="background-color: #ffcfcf"
 | [[bip-0345.mediawiki|345]]
 | Consensus (soft fork)
 | OP_VAULT
 | James O'Beirne, Greg Sanders
 | Standard
-| Draft
+| Withdrawn
 |-
 | [[bip-0347.mediawiki|347]]
 | Consensus (soft fork)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your comment, you may also want to add Superseded-By: [bip-number-of-OP_CCV-coming-soon™] below the Post-History header.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e., Superseded-By: 443.

@jonatack jonatack added the Proposed BIP modification PR by non-owner to update BIP content label May 6, 2025
@jamesob
jamesob force-pushed the jamesob-25-05-withdraw-vault branch from c09fcd6 to 65c0f7b Compare May 8, 2025 17:45
Comment thread README.mediawiki
| James O'Beirne, Greg Sanders
| Standard
| Draft
| Withdrawn

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 1130 should be

|- style="background-color: #ffcfcf"

to match the status change.

Comment thread bip-0345.mediawiki Outdated
Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0345
Status: Draft
Status: Withdrawn
Superseded-By: 443

@murchandamus murchandamus May 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the Superseded-By header below the Post-History header. The headers are required to be in a specific order.

@murchandamus

Copy link
Copy Markdown
Member

The CI is failing because of the color of the table row in the README.mediawiki

@murchandamus
murchandamus force-pushed the jamesob-25-05-withdraw-vault branch from 65c0f7b to b771054 Compare May 8, 2025 18:34
@murchandamus

Copy link
Copy Markdown
Member

Edited with permission of @jamesob to fix CI issue. Checked with @instagibbs out-of-band who supports the change.

@murchandamus
murchandamus merged commit 60ac0e8 into bitcoin:master May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants