Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Version prefixes for Segwit xpubs #680
Segwit wallets are still using xpub version prefix for segwit in p2sh/native segwit wallets. This is leading to incorrect address derivation from an xpub/xprv
Already in use by electrum, samouri and trezor
referenced this pull request
May 16, 2018
Hey @shivaenigma - thanks for the thought, but we don't modify BIP's to widen the scope after they have been finalized - given there already complete implementations of BIP32 in the wild.
Also these prefixes are already defined in SLIP-0132, and they should remain there IMO, unless someone wants to submit a standalone BIP for it. But the prefixes being defined in the SLIP repository haven't negatively affected their uptake. As you note, three wallets are using them already.
I think this PR is not acceptable due the above (though it's certainly not my place to decide that), but it may be acceptable if presented as a new BIP.
Indeed we have a draft for this as a new BIP at https://github.com/SomberNight/bips/blob/bip-xpub-versionbytes-extension/bip-xpub-versionbytes-extension.mediawiki