New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version prefixes for Segwit xpubs #680

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@shivaenigma
Copy link

shivaenigma commented May 16, 2018

Motivation

Segwit wallets are still using xpub version prefix for segwit in p2sh/native segwit wallets. This is leading to incorrect address derivation from an xpub/xprv

Reference Discussion

Implementation

Already in use by electrum, samouri and trezor

@afk11

This comment has been minimized.

Copy link
Contributor

afk11 commented May 16, 2018

Hey @shivaenigma - thanks for the thought, but we don't modify BIP's to widen the scope after they have been finalized - given there already complete implementations of BIP32 in the wild.

Also these prefixes are already defined in SLIP-0132, and they should remain there IMO, unless someone wants to submit a standalone BIP for it. But the prefixes being defined in the SLIP repository haven't negatively affected their uptake. As you note, three wallets are using them already.

I think this PR is not acceptable due the above (though it's certainly not my place to decide that), but it may be acceptable if presented as a new BIP.

@shivaenigma

This comment has been minimized.

Copy link
Author

shivaenigma commented May 16, 2018

@afk11 Totally Understand point about not modifying existing BIP. No Problem

I will create a new BIP

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented May 20, 2018

Please open a new PR when you have a new BIP draft ready, following review of the draft on the bitcoin-dev ML.

@luke-jr luke-jr closed this May 20, 2018

@ecdsa

This comment has been minimized.

Copy link

ecdsa commented May 26, 2018

@SomberNight you should submit your text here

@SomberNight

This comment has been minimized.

Copy link
Contributor

SomberNight commented May 26, 2018

Indeed we have a draft for this as a new BIP at https://github.com/SomberNight/bips/blob/bip-xpub-versionbytes-extension/bip-xpub-versionbytes-extension.mediawiki
I think I'll read it a few more times and potentially clean it up a bit, and submit it to the mailing list soon

@shivaenigma

This comment has been minimized.

Copy link
Author

shivaenigma commented May 28, 2018

@SomberNight Thanks ... looks good ..
I have few tests here. Feel free to copy

Looking forward to the submission to the mailing list

@clarkmoody

This comment has been minimized.

Copy link
Contributor

clarkmoody commented May 28, 2018

Why not submit updates and changes to SLIP-0132? There are (a few) test vectors and a generation code there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment