Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BIP: Signatures of Messages using Bitcoin Private Keys #764

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@cgilliard
Copy link

cgilliard commented Feb 18, 2019

As per BIP 2 process, creating pull request with filed named BIP-XXXX.mediawiki.

@luke-jr luke-jr added the New BIP label Feb 18, 2019

@luke-jr luke-jr changed the title create new bip proposal New BIP: Signatures of Messages using Bitcoin Private Keys Feb 18, 2019

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Feb 18, 2019

Missing backward compatibility section, and possibly a duplicate of BIP 127 and/or BIP 322.

@cgilliard

This comment has been minimized.

Copy link
Author

cgilliard commented Feb 19, 2019

@sipa

This comment has been minimized.

Copy link
Member

sipa commented Feb 19, 2019

BIP322 distinguishes fine between p2wpkh/p2pkh/p2sh-p2wpkh and much more (including multisig etc).

@cgilliard

This comment has been minimized.

Copy link
Author

cgilliard commented Feb 19, 2019

@cgilliard

This comment has been minimized.

Copy link
Author

cgilliard commented Feb 20, 2019

Made update to reference the newer signature format (BIP311) and indicate this is only to document existing signatures. Also, added backwards compatibility section and a section on signing/verification which includes non-segwit signatures too.

cgilliard added some commits Feb 20, 2019

@cgilliard

This comment has been minimized.

Copy link
Author

cgilliard commented Feb 27, 2019

I incorporated all the feedback that I received here and through the mailing list and through other emails. As you can see I'm linking to the newer BIP, but since Trezor and others have implemented this I thought it was important to document somewhere. If there's anything else that needs to be done, let me know.

@ravikantcool2008

This comment has been minimized.

Copy link

ravikantcool2008 commented Feb 27, 2019

Thanks

Show resolved Hide resolved bip-XXXX.mediawiki Outdated
Show resolved Hide resolved bip-XXXX.mediawiki Outdated
Show resolved Hide resolved bip-XXXX.mediawiki Outdated

cgilliard added some commits Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.