Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP174: Input Finalizer finalized fields clarifications #771

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@bitschmidty
Copy link

bitschmidty commented Mar 19, 2019

While the Transaction Extractor section calls out the 0x05 Finalized scriptSig and 0x06 Finalized scriptWitness, this wasn’t as clear in the Input Finalizer section.

@bitschmidty bitschmidty changed the title Input Finalizer finalized fields clarifications BIP174: Input Finalizer finalized fields clarifications Mar 19, 2019

@kallerosenbaum

This comment has been minimized.

Copy link
Contributor

kallerosenbaum commented Mar 24, 2019

It's actually 0x07 (Finalized scriptSig) and 0x08 (Finalized scriptWitness). The references are wrong in the Transaction Extractor section. See #765

Mike Schmidt
@bitschmidty

This comment has been minimized.

Copy link
Author

bitschmidty commented Mar 25, 2019

@kallerosenbaum Thank you, I should have verified what I was referencing! Corrections made.

@kallerosenbaum

This comment has been minimized.

Copy link
Contributor

kallerosenbaum commented Mar 25, 2019

Ok, but now this PR conflicts with pending PR #765 that fixes the errors in "Input Finalizer" section.

@bitschmidty

This comment has been minimized.

Copy link
Author

bitschmidty commented Mar 26, 2019

Updated to remove conflict

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 29, 2019

@achow101

This comment has been minimized.

Copy link
Member

achow101 commented Mar 29, 2019

Please squash.

Otherwise, ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.