Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdraw BIP151 #772

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@jonasschnelli
Copy link
Member

jonasschnelli commented Mar 22, 2019

The BIP151 proposal does have some practical downsides and thus a new proposal has been made (https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52)

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 29, 2019

BIP 151 never left Draft status, so why not just revise it?

@sipa

This comment has been minimized.

Copy link
Member

sipa commented Mar 29, 2019

Given that BIP151 already has an assigned number, I think it would be inadvisable to keep using the same number for a substantially different design.

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 29, 2019

Number assignment is not finalisation. Maybe if there was a production implementation of it, but as a mere draft, I don't see why. The new one is still "Peer-to-Peer Communication Encryption", no?

@jonasschnelli

This comment has been minimized.

Copy link
Member Author

jonasschnelli commented Mar 29, 2019

The main reason why this number/proposal should and probably cannot be re-used for a new, heavy incompatible proposal is, that implementations have been made (bcoin, armory). I don't think they are (no longer) in production but still,... the code is available.

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 29, 2019

I'm not really convinced, but not worth spending time arguing...

The README needs a style change, though: |- style="background-color: #ffcfcf"

@jonasschnelli jonasschnelli force-pushed the jonasschnelli:2019/03/withdraw_BIP151 branch from 6a793b7 to c7dee9d Mar 29, 2019

@jonasschnelli

This comment has been minimized.

Copy link
Member Author

jonasschnelli commented Mar 29, 2019

The README needs a style change, though: |- style="background-color: #ffcfcf"

Done.

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 29, 2019

... the style change is needed for BIP 151, not BIP 152 ;)

@jonasschnelli jonasschnelli force-pushed the jonasschnelli:2019/03/withdraw_BIP151 branch from c7dee9d to 73d06b4 Mar 29, 2019

@jonasschnelli

This comment has been minimized.

Copy link
Member Author

jonasschnelli commented Mar 29, 2019

Fixed

@luke-jr luke-jr merged commit 618a3e5 into bitcoin:master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.