Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bip174 extensions #849

Merged
merged 3 commits into from Nov 4, 2019
Merged

Bip174 extensions #849

merged 3 commits into from Nov 4, 2019

Conversation

@achow101
Copy link
Member

achow101 commented Oct 2, 2019

This PR specifies 2 new types and clarifies multi-byte types as was discussed on the mailing list a few months ago.

A version type of 0xFB is added in the event that there is a breaking change to PSBT.

A proprietary type of 0xFC is added to allow for proprietary use types for use in private. This type is followed by an identifier string and then a vendor defined subtype.

Lastly, multi-byte types are clarified. Types are redefined to be minimally encoded compact size unsigned integers so they can be variable length now if we happen to run out of one byte types somehow.

stevenroose added a commit to ElementsProject/elements that referenced this pull request Oct 9, 2019
…IP 174

34e1350 Use Elements PSBT magic when in Elements mode (Andrew Chow)
3fa355c Change Proprietary types to use the method specified in BIP 174 (Andrew Chow)

Pull request description:

  bitcoin/bips#849 (not yet merged) adds to BIP 174 proprietary types. This PR changes the PSBT types used in Elements to be in line with the proposed changes to the BIP/

Tree-SHA512: 73085a16005448d9f6ad1b74da4a40043ec29738256a439f35106793d11d0e95cb8d728db5cfefe1ddd49cd80367f7f5790d09efaa95bc443e1d6ba295240c4d
@luke-jr luke-jr merged commit daed7bf into bitcoin:master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
SomberNight added a commit to SomberNight/electrum that referenced this pull request Nov 7, 2019
based on latest BIP-0174 update: bitcoin/bips#849
SomberNight added a commit to SomberNight/electrum that referenced this pull request Nov 7, 2019
based on latest BIP-0174 update: bitcoin/bips#849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.