Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP 179: Name for payment recipient identifiers #856

Conversation

@emilengler
Copy link
Contributor

emilengler commented Oct 17, 2019

This was discussed here and got really good feedback.
This is the BIP draft for it.
Feedback appreciated.

Copy link
Member

MarcoFalke left a comment

Thanks! Concept ACK

<pre>
BIP: UNDEFINED
Titel: Redefinition of the term address
Author: Emil Engler <me@emilengler.com>

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Oct 17, 2019

Member

I'd suggest to find one co-author, so that potential changes to the BIP can be addressed by either

This comment has been minimized.

Copy link
@emilengler

emilengler Oct 17, 2019

Author Contributor

Good idea, I will ask on the ML

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Oct 17, 2019

Member

If no one else steps up, you can put me in.

@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Oct 17, 2019

@MarcoFalke Done, also asked on the ML

@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Oct 17, 2019

BIP title has changed, could someone change the title of the PR?
I have insufficient permissions.

@luke-jr luke-jr changed the title Add BIP: Redefinition of the term address New BIP: Replacing the term address Oct 17, 2019
@luke-jr luke-jr changed the title New BIP: Replacing the term address New BIP: Terminology for payment recipient identifiers Oct 17, 2019
@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Oct 21, 2019

@MarcoFalke I added you as a co-author as no responded so far.
Which E-Mail should I use?

@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch from 55296f6 to 446d763 Oct 23, 2019
@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Oct 23, 2019

Squashed, could this get a BIP number now as it is probably ready? @luke-jr

A ''Bitcoin'' Invoice ''Address'' is a string of characters that can be used to indicate the intended recipient and purpose of a transaction.

==Motivation==
Bitcoin addresses are intended to be only used '''once''' and you should generate a new one for every new incoming payment.

This comment has been minimized.

Copy link
@Xekyo

Xekyo Oct 25, 2019

Shouldn't this sentence start with Bitcoin invoice addresses…? 😁

This comment has been minimized.

Copy link
@emilengler

emilengler Oct 26, 2019

Author Contributor

It describes a problem of the past and currently the present so I think it will be fine there. :P

@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch 2 times, most recently from ed1896b to 262771a Oct 26, 2019
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 4, 2019

@luke-jr Is this ready?

@luke-jr luke-jr changed the title New BIP: Terminology for payment recipient identifiers New BIP 179: Terminology for payment recipient identifiers Nov 4, 2019
@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Nov 4, 2019

Assigned BIP 179

@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Nov 4, 2019

@luke-jr Thanks, will modify the text

@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch from 25b3357 to 1ccd4c0 Nov 4, 2019
@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Nov 4, 2019

@luke-jr Thanks, updated, squashed and reworded.
What's next?

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Nov 5, 2019

bip-0179.mediawiki has too-long TItle (45 > 44 char max) at scripts/buildtable.pl line 126, <$F> line 3.
@@ -0,0 +1,56 @@
<pre>
BIP: 179
Title: Terminology for payment recipient identifiers

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Nov 5, 2019

Member

Hmm interesting travis failure:

bip-0179.mediawiki has too-long TItle (45 > 44 char max) at scripts/buildtable.pl line 126, <$F> line 3.

This comment has been minimized.

Copy link
@emilengler

emilengler Nov 5, 2019

Author Contributor

Looks like this BIP needs a new name, any suggestions?

This comment has been minimized.

Copy link
@luke-jr

luke-jr Nov 5, 2019

Member

"Name for payment recipient identifiers" maybe?

This comment has been minimized.

Copy link
@emilengler

emilengler Nov 5, 2019

Author Contributor

@luke-jr
ACK, it is 39 chars.
Could you please update the title again...

This comment has been minimized.

Copy link
@emilengler

emilengler Nov 5, 2019

Author Contributor

Updated and forced pushed

@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch from 1ccd4c0 to d43f13a Nov 5, 2019
@luke-jr luke-jr changed the title New BIP 179: Terminology for payment recipient identifiers BIP 179: Name for payment recipient identifiers Nov 5, 2019
@luke-jr luke-jr added the New BIP label Nov 5, 2019
bip-0179.mediawiki Outdated Show resolved Hide resolved
@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch from d43f13a to 1108fd7 Nov 6, 2019
@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch from 1108fd7 to 70a163c Nov 6, 2019
@emilengler emilengler force-pushed the emilengler:emilengler-redefinition-of-the-term-address branch from 70a163c to d3ff4b1 Nov 7, 2019
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 7, 2019

@luke-jr luke-jr merged commit 8431b22 into bitcoin:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emilengler

This comment has been minimized.

Copy link
Contributor Author

emilengler commented Nov 8, 2019

@luke-jr Thanks for merging, what are the next steps until it gets accepted and reaches final?

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 8, 2019

@emilengler BIPs aren't "accepted" there is no central authority that could do that. A BIP is merged in the repo after basic formatting rules have been obeyed. Anyone is free to not implement or to implement a BIP.

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Nov 8, 2019

The BIP Status field exists to reflect real-world status, so lacking specific conditions in BIP 2 (AFAICT), I guess it should become "Active" when there is a very obvious trend of adopting the proposed language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.