Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP174: Fix wrong description about Proprietary Use Type #860

Open
wants to merge 1 commit into
base: master
from

Conversation

@azuchi
Copy link
Contributor

azuchi commented Nov 14, 2019

About BIP-174, PSBT_GLOBAL_PROPRIETARY, PSBT_INPUT_PROPRIETARY, PSBT_OUTPUT_PROPRIETARY key description is incorrectly described as Version Number, so it fix to Proprietary Use Type.

@junderw

This comment has been minimized.

Copy link
Contributor

junderw commented Nov 14, 2019

ACK

@achow101

This comment has been minimized.

Copy link
Member

achow101 commented Nov 14, 2019

ACK 87a8540

That's what I get for copy-pasting.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 19, 2019

@dgpv

This comment has been minimized.

Copy link

dgpv commented Dec 2, 2019

Shouldn't the names for proprietary input and output types be PSBT_IN_PROPRIETARY, PSBT_OUT_PROPRIETARY, to be consistent with other input/output type names ?

@dgpv

This comment has been minimized.

Copy link

dgpv commented Dec 2, 2019

(Also it seems that proprietary types are missing from Appendix A)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.