Bitcoin Core integration/staging tree
Clone or download
MarcoFalke Merge #14287: tests: Use MakeUnique to construct objects owned by uni…
…que_ptrs

b6718e3 tests: Use MakeUnique to construct objects owned by unique_ptrs (practicalswift)

Pull request description:

  A subset of #14211 ("Use MakeUnique to construct objects owned by unique_ptrs") as suggested by @MarcoFalke in #14211 (comment).

  Use `MakeUnique` to construct objects owned by `unique_ptr`s.

  Rationale:
  * `MakeUnique` ensures exception safety in complex expressions.
  * `MakeUnique` gives a more concise statement of the construction.

Tree-SHA512: 1228ae6ce7beb178d79142c4e936b728178ccaa8aa35c6d8feeb33d1a667abfdd010c59996a9d833594611e913877ce5794e75953d11d9b1fdbac04aa491d9cf
Latest commit 920c090 Sep 19, 2018
Permalink
Failed to load latest commit information.
.github Make default issue text all comments to make issues more readable Nov 16, 2017
.travis travis: Run feature_dbcrash functional tests in cron job Sep 16, 2018
.tx tx: Update transifex slug 016x→017x Aug 2, 2018
build-aux/m4 Merge #13095: build: update ax_boost_chrono/unit_test_framework Jul 26, 2018
build_msvc appveyor: Use clcache to speed up build Sep 3, 2018
contrib Merge #13954: Warn (don't fail!) on spelling errors. Fix typos report… Sep 5, 2018
depends [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zero… Sep 11, 2018
doc Merge #14287: tests: Use MakeUnique to construct objects owned by uni… Sep 19, 2018
share Merge #14018: Bugfix: NSIS: Exclude Makefile* from docs Aug 22, 2018
src Merge #14287: tests: Use MakeUnique to construct objects owned by uni… Sep 19, 2018
test init: Remove deprecated args from hidden args Sep 19, 2018
.gitattributes Separate protocol versioning from clientversion Oct 29, 2014
.gitignore [build] .gitignore: add QT Creator artifacts Dec 22, 2017
.travis.yml travis: add CXXFLAGS=-Wnopsabi at ARM job Aug 27, 2018
CONTRIBUTING.md doc: add note to contributor docs about warranted PR's Jul 30, 2018
COPYING [Trivial] Update license year range to 2018 Dec 31, 2017
INSTALL.md Update INSTALL landing redirection notice for build instructions. Oct 5, 2016
Makefile.am contrib: Remove debian and rpm subfolders Jul 30, 2018
README.md doc: Adjust bitcoincore.org links Jul 22, 2018
appveyor.yml appveyor: Use clcache to speed up build Sep 3, 2018
autogen.sh Add "export LC_ALL=C" to all shell scripts Jun 14, 2018
configure.ac Merge #14127: build: avoid getifaddrs when unavailable Sep 10, 2018
libbitcoinconsensus.pc.in Unify package name to as few places as possible without major changes Dec 14, 2015

README.md

Bitcoin Core integration/staging tree

Build Status

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.