Skip to content
Bitcoin Core integration/staging tree
Branch: master
Clone or download
MarcoFalke Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic
faca95e qa: Make swap_magic_bytes in p2p_invalid_messages atomic (MarcoFalke)

Pull request description:

  Otherwise, this will lead to errors logged in the network thread:

  https://travis-ci.org/MarcoFalke/bitcoin/jobs/513076282#L2765

ACKs for commit faca95:

Tree-SHA512: 8bc8280f9c0e8d40bc68c0ff1cab1c3386cbfef0728dbab5f29c2606dd65a9ac3c695b0c286be707a9f2bd62a6f87ac2032d7749fc2cf8b9fa1eba3c4cf70933
Latest commit 40a720a Apr 23, 2019
Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
.github Get more info about GUI-related issue on Linux Dec 27, 2018
.travis travis: Switch to ubuntu keyserver to avoid timeouts Mar 29, 2019
.tx qt: Pre-0.18 split-off translations update Feb 4, 2019
build-aux/m4 Bump minimum Qt version to 5.5.1 Feb 14, 2019
build_msvc bench: Add wallet_balance benchmarks Apr 15, 2019
contrib contrib: gh-merge: Use pagination to fetch all review comments Apr 17, 2019
depends Merge #15446: Improve depends debuggability Apr 8, 2019
doc Merge #15821: doc: Remove upgrade note in release notes from EOL vers… Apr 18, 2019
share Merge #15548: build: use full version string in setup.exe Mar 12, 2019
src Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconne… Apr 23, 2019
test Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic Apr 23, 2019
.appveyor.yml appveyor: Don't build debug libraries instead of "build and delete" Feb 28, 2019
.cirrus.yml cirrus ci: Inital config Feb 3, 2019
.gitattributes Separate protocol versioning from clientversion Oct 29, 2014
.gitignore gitignore: add *.plist (clang-check) Apr 12, 2019
.python-version .python-version: Specify full version 3.5.6 Mar 2, 2019
.style.yapf test: .style.yapf: Set column_limit=160 Mar 4, 2019
.travis.yml travis: Bump second timeout to 33 minutes, Add rationale Apr 11, 2019
CONTRIBUTING.md Doc: update ACK description in CONTRIBUTING.md Mar 20, 2019
COPYING [Trivial] Update license year range to 2019 Dec 31, 2018
INSTALL.md Update INSTALL landing redirection notice for build instructions. Oct 5, 2016
Makefile.am Merge #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis Feb 14, 2019
README.md docs: Update Transifex links Mar 2, 2019
autogen.sh Add "export LC_ALL=C" to all shell scripts Jun 14, 2018
configure.ac build: Require python 3.5 Mar 2, 2019
libbitcoinconsensus.pc.in Unify package name to as few places as possible without major changes Dec 14, 2015

README.md

Bitcoin Core integration/staging tree

Build Status

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.

You can’t perform that action at this time.