Skip to content
Permalink
Browse files

Merge #8915: Add copyright/patent issues to possible NACK reasons

36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
  • Loading branch information...
MarcoFalke committed Oct 14, 2016
2 parents e2b8c39 + 36f60a5 commit 03dd707dc027fbf6f24120213f8eb66571600374
Showing with 3 additions and 1 deletion.
  1. +3 −1 CONTRIBUTING.md
@@ -178,7 +178,9 @@ language is used within pull-request comments:

- ACK means "I have tested the code and I agree it should be merged";
- NACK means "I disagree this should be merged", and must be accompanied by
sound technical justification. NACKs without accompanying reasoning may be disregarded;
sound technical justification (or in certain cases of copyright/patent/licensing
issues, legal justification). NACKs without accompanying reasoning may be
disregarded;
- utACK means "I have not tested the code, but I have reviewed it and it looks
OK, I agree it can be merged";
- Concept ACK means "I agree in the general principle of this pull request";

0 comments on commit 03dd707

Please sign in to comment.
You can’t perform that action at this time.