Browse files

Merge #7781: devtools: Auto-set branch to merge to in github-merge

10d3ae1 devtools: Auto-set branch to merge to in github-merge (Wladimir J. van der Laan)
  • Loading branch information...
laanwj committed Apr 5, 2016
2 parents 214ec0b + 10d3ae1 commit 55db5f07b1c4e82181f691725212587fcafd6f2a
Showing with 22 additions and 12 deletions.
  1. +22 −12 contrib/devtools/
@@ -47,19 +47,19 @@ def git_config_get(option, default=None):
except subprocess.CalledProcessError as e:
return default
def retrieve_pr_title(repo,pull):
def retrieve_pr_info(repo,pull):
Retrieve pull request title from github.
Retrieve pull request information from github.
Return None if no title can be found, or an error happens.
req = Request(""+repo+"/pulls/"+pull)
result = urlopen(req)
reader = codecs.getreader('utf-8')
obj = json.load(reader(result))
return obj['title']
return obj
except Exception as e:
print('Warning: unable to retrieve pull title from github: %s' % e)
print('Warning: unable to retrieve pull information from github: %s' % e)
return None
def ask_prompt(text):
@@ -69,28 +69,28 @@ def ask_prompt(text):
return reply
def parse_arguments(branch):
def parse_arguments():
epilog = '''
In addition, you can set the following git configuration variables:
githubmerge.repository (mandatory),
user.signingkey (mandatory), (default:,
githubmerge.branch (default: master),
githubmerge.branch (no default),
githubmerge.testcmd (default: none).
parser = argparse.ArgumentParser(description='Utility to merge, sign and push github pull requests',
parser.add_argument('pull', metavar='PULL', type=int, nargs=1,
help='Pull request ID to merge')
parser.add_argument('branch', metavar='BRANCH', type=str, nargs='?',
default=branch, help='Branch to merge against (default: '+branch+')')
default=None, help='Branch to merge against (default: githubmerge.branch setting, or base branch for pull, or \'master\')')
return parser.parse_args()
def main():
# Extract settings from git repo
repo = git_config_get('githubmerge.repository')
host = git_config_get('','')
branch = git_config_get('githubmerge.branch','master')
opt_branch = git_config_get('githubmerge.branch',None)
testcmd = git_config_get('githubmerge.testcmd')
signingkey = git_config_get('user.signingkey')
if repo is None:
@@ -105,9 +105,20 @@ def main():
host_repo = host+":"+repo # shortcut for push/pull target
# Extract settings from command line
args = parse_arguments(branch)
args = parse_arguments()
pull = str(args.pull[0])
branch = args.branch
# Receive pull information from github
info = retrieve_pr_info(repo,pull)
if info is None:
title = info['title']
# precedence order for destination branch argument:
# - command line argument
# - githubmerge.branch setting
# - base branch for pull (as retrieved from github)
# - 'master'
branch = args.branch or opt_branch or info['base']['ref'] or 'master'
# Initialize source branches
head_branch = 'pull/'+pull+'/head'
@@ -147,7 +158,6 @@ def main():
# Create unsigned merge commit.
title = retrieve_pr_title(repo,pull)
if title:
firstline = 'Merge #%s: %s' % (pull,title)
@@ -165,7 +175,7 @@ def main():
print("ERROR: Creating merge failed (already merged?).",file=stderr)
print('%s#%s%s %s' % (ATTR_RESET+ATTR_PR,pull,ATTR_RESET,title))
print('%s#%s%s %s %sinto %s%s' % (ATTR_RESET+ATTR_PR,pull,ATTR_RESET,title,ATTR_RESET+ATTR_PR,branch,ATTR_RESET))
# Run test command if configured.

0 comments on commit 55db5f0

Please sign in to comment.