Skip to content
Browse files

rpc/gui: Remove 'Unknown block versions being mined' warning

Due to miners inserting garbage into the version numbers, the current
version signalling has become completely useless. This removes the
"unknown block versions" warning which has the tendency to scare
users unnecessarily (and might get them to "update" to something

It preserves the warning in the logs. Whether this is desirable can
be a point of discussion.
  • Loading branch information...
laanwj committed Feb 25, 2019
1 parent 1a8a5ed commit 6154e506597f61fb3f0156d737d8221dcab882aa
Showing with 0 additions and 6 deletions.
  1. +0 −6 src/validation.cpp
@@ -2259,12 +2259,6 @@ void static UpdateTip(const CBlockIndex *pindexNew, const CChainParams& chainPar
if (nUpgraded > 0)
AppendWarning(warningMessages, strprintf(_("%d of last 100 blocks have unexpected version"), nUpgraded));
if (nUpgraded > 100/2)
std::string strWarning = _("Warning: Unknown block versions being mined! It's possible unknown rules are in effect");
// notify GetWarnings(), called by Qt and the JSON-RPC code to warn the user:
LogPrintf("%s: new best=%s height=%d version=0x%08x log2_work=%.8g tx=%lu date='%s' progress=%f cache=%.1fMiB(%utxo)", __func__, /* Continued */
pindexNew->GetBlockHash().ToString(), pindexNew->nHeight, pindexNew->nVersion,

0 comments on commit 6154e50

Please sign in to comment.
You can’t perform that action at this time.