Correctly report high-S violations

sipa · laanwj · commit 889e5b3050e7 · 2016-02-10T20:32:42.000+01:00
Github-Pull: #7500 Rebased-From: 9d95187
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
@@ -165,7 +165,10 @@ bool static IsLowDERSignature(const valtype &vchSig, ScriptError* serror) {
         return set_error(serror, SCRIPT_ERR_SIG_DER);
     }
     std::vector<unsigned char> vchSigCopy(vchSig.begin(), vchSig.begin() + vchSig.size() - 1);
-    return CPubKey::CheckLowS(vchSigCopy);
+    if (!CPubKey::CheckLowS(vchSigCopy)) {
+        return set_error(serror, SCRIPT_ERR_SIG_HIGH_S);
+    }
+    return true;
 }
 
 bool static IsDefinedHashtypeSignature(const valtype &vchSig) {

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,10 @@ bool static IsLowDERSignature(const valtype &vchSig, ScriptError* serror) {`
`165`	`165`	`return set_error(serror, SCRIPT_ERR_SIG_DER);`
`166`	`166`	`}`
`167`	`167`	`std::vector<unsigned char> vchSigCopy(vchSig.begin(), vchSig.begin() + vchSig.size() - 1);`
`168`		`- return CPubKey::CheckLowS(vchSigCopy);`
	`168`	`+ if (!CPubKey::CheckLowS(vchSigCopy)) {`
	`169`	`+ return set_error(serror, SCRIPT_ERR_SIG_HIGH_S);`
	`170`	`+ }`
	`171`	`+ return true;`
`169`	`172`	`}`
`170`	`173`
`171`	`174`	`bool static IsDefinedHashtypeSignature(const valtype &vchSig) {`