Browse files

torcontrol: Explicitly request RSA1024 private key

When generating a new service key, explicitly request a RSA1024 one.

The bitcoin P2P protocol has no support for the longer hidden service names
that will come with ed25519 keys, until it does, we depend on the old
hidden service type so make this explicit.

See #9214.

Rebased-From: 7d3b627
Github-Pull: #9234
  • Loading branch information...
1 parent 9460771 commit 94531b53509470e01dcbd90275577cb37a794fa8 @laanwj laanwj committed Nov 28, 2016
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/torcontrol.cpp
@@ -469,7 +469,7 @@ void TorController::auth_cb(TorControlConnection& conn, const TorControlReply& r
// Finally - now create the service
if (private_key.empty()) // No private key, generate one
- private_key = "NEW:BEST";
+ private_key = "NEW:RSA1024"; // Explicitly request RSA1024 - see issue #9214
// Request hidden service, redirect port.
// Note that the 'virtual' port doesn't have to be the same as our internal port, but this is just a convenient
// choice. TODO; refactor the shutdown sequence some day.

0 comments on commit 94531b5

Please sign in to comment.