-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
f261f19 Give a better error message if system clock is bad (Casey Rodarmor)
- Loading branch information
Showing
1 changed file
with
12 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9c017a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cause the node to get stuck for 70 minutes if a Sybil attack on the node's peer time removes 70 minutes from local time right after it sees a block with a timestamp that is 120 minutes in the future?
c9c017a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code didn't change semantics at all, it only shows a warning to the user when the clock seems off. It's also 5 years old.
c9c017a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so it is only a message and does not cause a problem in the node's functioning? I'm trying to understand why ZEC's sudden security fix (that replaces allowed peer offset of 70 minutes with 0 and makes future time limit FTL based on MTP instead of local time) reportedly fixes this:
https://electriccoin.co/blog/new-releases-2-1-1-and-hotfix-2-1-1-1/