Skip to content
Permalink
Branch: 0.19
Commits on Jan 20, 2020
  1. Merge #17792: 0.19: Backports

    laanwj committed Jan 20, 2020
    cd67b1d Use correct C++11 header for std::swap() (Hennadii Stepanov)
    b8101fb Fix comparison function signature (Hennadii Stepanov)
    eac4907 Don't allow implementers to think ScriptHash(Witness*()) results in nesting computation (Gregory Sanders)
    e2c45d8 IsUsedDestination shouldn't use key id as script id for ScriptHash (Gregory Sanders)
    a5489c9 IsUsedDestination should count any known single-key address (Gregory Sanders)
    88729d8 Fix issue with conflicted mempool tx in listsinceblock (Adam Jonas)
    eafcea7 gui: Fix duplicate wallet showing up (João Barbosa)
    7e66d04 Drop signal CClientUIInterface::LoadWallet (Russell Yanofsky)
    179d55f zmq: Fix due to invalid argument and multiple notifiers (João Barbosa)
    
    Pull request description:
    
      Backports
       - #16963
       - #17445
       - #17258
       - #17621
       - #17924
       - #17634
    
    ACKs for top commit:
      laanwj:
        ACK cd67b1d, checked that I got more or less the same result (including conflict resolution) backporting these commits
    
    Tree-SHA512: 645786267cfb10a01a56f7cfd91ddead5f1475df5714595ae480237e04d40c5cfb7460b40532279cacd83e4b775a4ace68a258ec2184b8ad0e997a690a9245e5
Commits on Jan 15, 2020
  1. Use correct C++11 header for std::swap()

    hebasto authored and promag committed Nov 29, 2019
    Github-Pull: #17634
    Rebased-From: 98fbd1c
  2. Fix comparison function signature

    hebasto authored and promag committed Nov 29, 2019
    This commit fixes build on CentOS 7 with GCC 4.8.5
    
    Github-Pull: #17634
    Rebased-From: b66861e
  3. Don't allow implementers to think ScriptHash(Witness*()) results in n…

    instagibbs authored and promag committed Jan 14, 2020
    …esting computation
    
    Github-Pull: #17924
    Rebased-From: 6dd59d2
  4. IsUsedDestination shouldn't use key id as script id for ScriptHash

    instagibbs authored and promag committed Jan 14, 2020
    Github-Pull: #17924
    Rebased-From: 4b8f1e9
Commits on Jan 14, 2020
  1. IsUsedDestination should count any known single-key address

    instagibbs authored and promag committed Nov 27, 2019
    Github-Pull: #17621
    Rebased-From: 0950245
  2. Fix issue with conflicted mempool tx in listsinceblock

    adamjonas authored and promag committed Oct 21, 2019
    listsinceblock now checks that returned transactions are not
    conflicting with any transactions that are filtered out by
    the given blockhash
    
    Co-Authored-By: Michael Chrostowski <michael.chrostowski@gmail.com>
    
    Github-Pull: #17258
    Rebased-From: 436ad43
  3. gui: Fix duplicate wallet showing up

    promag committed Sep 26, 2019
    The slot BitcoinGUI::addWallet can be invoked twice for the same
    WalletModel due to a concurrent wallet being loaded after the first `connect()`:
    
    ```cpp
     connect(wallet_controller, &WalletController::walletAdded, this, &BitcoinGUI::addWallet);
     connect(wallet_controller, &WalletController::walletRemoved, this, &BitcoinGUI::removeWallet);
    
     for (WalletModel* wallet_model : m_wallet_controller->getOpenWallets()) {
         addWallet(wallet_model);
    ```
    
    Github-Pull: #16963
    Rebased-From: 6d6a7a8
  4. Drop signal CClientUIInterface::LoadWallet

    ryanofsky authored and promag committed Sep 27, 2019
    Github-Pull: #16963
    Rebased-From: 81ea66c
  5. zmq: Fix due to invalid argument and multiple notifiers

    promag committed Nov 11, 2019
    Github-Pull: #17445
    Rebased-From: 3e730bf
Commits on Jan 8, 2020
  1. Merge #17858: [0.19] Backports

    laanwj committed Jan 8, 2020
    99b5407 scripts: fix check-symbols & check-security argument passing (fanquake)
    4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson)
    b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson)
    cd7b3b2 Updated appveyor config:  - Update build image from Visual Studio 2017 to Visual Studio 2019.  - Updated Qt static library from Qt5.9.7 to Qt5.9.8.  - Added commands to update vcpkg port files (this does not update already installed packages).  - Updated vcpkg package list as per #17309.  - Removed commands setting common project file options. Now done via common.init.vcxproj include.  - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs:  - Updated platform toolset from v141 to v142.  - Updated Qt static library from Qt5.9.7 to Qt5.9.8.  - Added ignore for linker warning building bitcoin-qt program.  - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson)
    112144d Add missing typeinfo includes (Wladimir J. van der Laan)
    1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan)
    c0dc728 test: fix bitcoind already running warnings on macOS (fanquake)
    5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov)
    4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow)
    bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris)
    d14ab7c gui: disable File->CreateWallet during startup (fanquake)
    b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich)
    
    Pull request description:
    
      Backports the following PRs to the 0.19 branch:
      * #17654 - Unbreak build with Boost 1.72.0
      * #17695 - gui: disable File->CreateWallet during startup
      * #17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice
      * #17728 - rpc: require second argument only for scantxoutset start action
      * #17450 - util: Add missing headers to util/fees.cpp
      * #17488 - test: fix "bitcoind already running" warnings on macOS
      * #17762 - Log to net category for exceptions in ProcessMessages
      * #17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes
      * #17416 - Appveyor improvement - text file for vcpkg package list
      * #17736 - Update msvc build for Visual Studio 2019 v16.4
      * #17857 - scripts: fix symbol-check & security-check argument passing
    
      Fixes #17856.
    
    ACKs for top commit:
      sipsorcery:
        ACK (tested: Windows 10 & msvc build) 99b5407.
    
    Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb
  2. qt: Periodic translations update for 0.19 branch

    laanwj committed Jan 8, 2020
    Brings back `bitcoin_en` which was accidentally removed last time (see #17886).
    
    Tree-SHA512: a4aaa6f22e9ad3e87952f2a87829d675158cb26ed1fe61ef8e62646c22e21ccc0dec0f890b726f8adb76d7609e0274af8574b67201d30eff941cb60b1b76ff8c
Commits on Jan 6, 2020
  1. scripts: fix check-symbols & check-security argument passing

    fanquake committed Jan 3, 2020
    The first argument in bin_PROGRAMS (bitcoind) was being silently
    dropped and never passed into the check-security.py or check-symbols.py scripts.
    
    This has been the case since the scripts were added to the makefile in
    f3d3eaf.
    
    Example of the behavior:
    
    ```python
    
    import sys
    if __name__ == '__main__':
        print(sys.argv)
        # ['args.py', 'b', 'c']
    
        # if you add some lines to "a",
        # you'll see them here..
        for line in sys.stdin:
            print(line)
    ```
    
    Github-Pull: #17857
    Rebased-From: 71af793
Commits on Jan 5, 2020
  1. Update msvc build for Visual Studio 2019 v16.4

    sipsorcery authored and fanquake committed Dec 12, 2019
    msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant).
    An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4.
    
    Github-Pull: #17736
    Rebased-From: 75d9317
  2. Moves vcpkg list to a text file and updates the appveyor job and read…

    sipsorcery authored and fanquake committed Nov 10, 2019
    …me to use it.
    
    Github-Pull: #17416
    Rebased-From: 29eb039
  3. Updated appveyor config:

    sipsorcery authored and fanquake committed Nov 6, 2019
     - Update build image from Visual Studio 2017 to Visual Studio 2019.
     - Updated Qt static library from Qt5.9.7 to Qt5.9.8.
     - Added commands to update vcpkg port files (this does not update already installed packages).
     - Updated vcpkg package list as per #17309.
     - Removed commands setting common project file options. Now done via common.init.vcxproj include.
     - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration.
    Updated msvc project configs:
     - Updated platform toolset from v141 to v142.
     - Updated Qt static library from Qt5.9.7 to Qt5.9.8.
     - Added ignore for linker warning building bitcoin-qt program.
     - Added missing util/str.cpp class file to test_bitcoin project file.
    
    Github-Pull: #17364
    Rebased-From: 3c84dee
Commits on Jan 4, 2020
  1. Add missing typeinfo includes

    laanwj authored and fanquake committed Jan 2, 2020
    The use of `typeid()` for logging exception types requires this include
    according to https://en.cppreference.com/w/cpp/language/typeid.
    
    Github-Pull: #17762
    Rebased-From: 4bdd68f
  2. net: Log to net category for exceptions in ProcessMessages

    laanwj authored and fanquake committed Dec 17, 2019
    Remove the forest of special exceptions, and simply log a short
    message to the NET logging category when an exception happens during
    packet processing. It is not good to panick end users with errors
    that any peer can generate (let alone writing to stderr).
    
    Github-Pull: #17762
    Rebased-From: 4d88c3d
  3. test: fix bitcoind already running warnings on macOS

    fanquake committed Nov 15, 2019
    On macOS, pidof installed via brew returns b'' rather than None.
    Account for this, to remove spurious warnings from the test_runner.
    
    Github-Pull: #17488
    Rebased-From: 1c23ea5
  4. Merge #17853: [0.19] psbt: handle unspendable psbts

    fanquake committed Jan 4, 2020
    ca5f8de Mark PSBTs spending unspendable outputs as invalid in analysis (Andrew Chow)
    5515833 Have a PSBTAnalysis state that indicates invalid PSBT (Andrew Chow)
    
    Pull request description:
    
      Backport of #17524
    
    ACKs for top commit:
      achow101:
        ACK ca5f8de
    
    Tree-SHA512: b5f2b951beb9477ac3176a0aade845654d2108ca3a9fbc72097ba4b4797df5419053d6b489bbaa03be08cb8cfdc37a83db8b7642ffa52d42b7aa8ea14aff39cc
  5. Merge #17859: [0.19] Fix origfee return for bumpfee with feerate arg

    fanquake committed Jan 4, 2020
    bd8c6f1 Fix origfee return for bumpfee with feerate arg (Gregory Sanders)
    
    Pull request description:
    
      Backport of Github-Pull: #17643
      Rebased-From: 02afb0c
    
    ACKs for top commit:
      fanquake:
        ACK bd8c6f1 - the appveyor failure is unrelated.
      instagibbs:
        utACK bd8c6f1
    
    Tree-SHA512: 7e420a3fe02503194b6fc8eae5277c46289cd6abe131b2513ad80422819e6bafbc7768e7be344d4132ebdbc24846d459ba2a271be184725d818dff77510fa4de
Commits on Jan 3, 2020
  1. Fix origfee return for bumpfee with feerate arg

    instagibbs authored and luke-jr committed Dec 1, 2019
    Github-Pull: #17643
    Rebased-From: 02afb0c
  2. util: Add missing headers to util/fees.cpp

    hebasto authored and fanquake committed Nov 12, 2019
    Github-Pull: #17450
    Rebased-From: b131524
  3. rpc: require second argument only for scantxoutset start action

    achow101 authored and fanquake committed Dec 11, 2019
    The second argument of scanobjects is only required for the start action.
    Stop and abort actions do not need this.
    
    Github-Pull: #17728
    Rebased-From: 7d26357
  4. cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic …

    brakmic authored and fanquake committed Dec 6, 2019
    …twice
    
    Github-Pull: #17687
    Rebased-From: 034561f
  5. gui: disable File->CreateWallet during startup

    fanquake committed Dec 7, 2019
    Github-Pull: #17695
    Rebased-From: d65fafc
  6. wallet: unbreak with boost 1.72

    jbeich authored and fanquake committed Dec 2, 2019
    wallet/walletutil.cpp:77:23: error: no member named 'level' in 'boost::filesystem::recursive_directory_iterator'
            } else if (it.level() == 0 && it->symlink_status().type() == fs::regular_file && IsBerkeleyBtree(it...
                       ~~ ^
    
    Github-Pull: #17654
    Rebased-From: a64e97d
  7. Mark PSBTs spending unspendable outputs as invalid in analysis

    achow101 authored and luke-jr committed Nov 19, 2019
    Github-Pull: #17524
    Rebased-From: 773d457
  8. Have a PSBTAnalysis state that indicates invalid PSBT

    achow101 authored and luke-jr committed Nov 19, 2019
    Invalid PSBTs need to be re-created, so the next role is the
    Creator (new PSBTRole). Additionally, we need to know what went
    wrong so an error field was added to PSBTAnalysis.
    
    A PSBTAnalysis indicating invalid will have empty everything,
    next will be set to PSBTRole::CREATOR, and an error message.
    
    Github-Pull: #17524
    Rebased-From: 638e40c
Commits on Nov 25, 2019
  1. refactor: Styling w/ clang-format, comment update

    hebasto authored and laanwj committed Nov 10, 2019
    Github-Pull: #17427
    Rebased-From: 1828c6f
    Tree-SHA512: 140b723bd9c8d8823ecb84d7f774d213a9e9dac45fb0de82c43521cf8276d946feaa1b7c0b7d40f51dbab38c88c53b4680da1965b1e0ce7f858eb35b2c4537da
  2. qt: Fix missing qRegisterMetaType for size_t

    hebasto authored and laanwj committed Nov 10, 2019
    It is required in order to use size_t in QueuedConnections.
    
    Github-Pull: #17427
    Rebased-From: 88a94f7
    Tree-SHA512: 55accd997209c559dfc8e88b0db189ba314ac31e265ba2f94fa2009f1aba6b96213e2aa8cbad492b1230078f2e6cf1cca7a233dc6f54e9bc449f4e5438330b4d
  3. doc: Clear out release notes after 0.19.0.1

    laanwj committed Nov 24, 2019
    Tree-SHA512: 4de65e8d0f91f9b16f374adb57a3cccc4421af47e1ef474d16afe520ca575f7b5acf871b805453a93c6e0ba1c61ab864a317df0af483da1c46c75d620e8e56d6
Commits on Nov 18, 2019
  1. doc: Generate manpages for 0.19.0.1

    laanwj committed Nov 18, 2019
    Tree-SHA512: d53a2bfa5bc589e7130cf8cd1627083ad7c72a197cbd80754c9dcf78e3775021fbd6426c5762f5f3e52e4b23ed06387c0be224914e0f98d14f3f7e51ee66c809
Commits on Nov 14, 2019
  1. doc: Re-add release notes of 0.19.0

    laanwj committed Nov 14, 2019
    Change version to 0.19.0.1.
    
    Add the following two PRs:
    - #17368 cli: fix -getinfo output when compiled with no wallet
    - #17449 fix uninitialized variable nMinerConfirmationWindow
    
    Add the following author:
    - NullFunctor (bitcoinVBR on gh)
    
    Tree-SHA512: f37b822555f2069c999721eede9156250d780e8906cd2e3294e7dfefc0225fff65ee3af4614fca081dcdccfab4a2a980192156621f005aa529bba00058da5c9a
  2. fix uninitialized variable nMinerConfirmationWindow

    NullFunctor authored and laanwj committed Nov 12, 2019
    fix uninitialized variable hard code the MinBIP9WarningHeight
    
    fix uninitialized var hard code the MinBIP9WarningHeight instead
    
    Github-Pull: #17449
    Rebased-From: edb6b76
    Tree-SHA512: 6192940e5e13ad1176aa380da9f3287ff1eb0c8c2a78571a6c45fe0e100417452c8503b9ffc5c8b2a89c4a5e8811b9d2bfec95366e1de00f3365ba06959e9a9a
Older
You can’t perform that action at this time.