Skip to content
Commits on May 10, 2016
  1. @MarcoFalke
  2. @MarcoFalke
  3. @MarcoFalke
  4. @error10 @MarcoFalke

    Increase timeout waiting for pruned blk00000.dat

    In my ever-growing list of test failures, I was seeing this one intermittently.
    
    ```
    Running 2nd level testscript pruning.py...
    Initializing test directory /tmp/testY5ypCv
    Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours)
    Mining a big blockchain of 995 blocks
    Check that we haven't started pruning yet because we're below PruneAfterHeight
    Success
    Though we're already using more than 550MB, current usage: 587
    Mining 25 more blocks should cause the first block file to be pruned
    Assertion failed: blk00000.dat not pruned when it should be
      File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main
        self.run_test()
      File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test
        self.test_height_min()
      File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min
        raise AssertionError("blk00000.dat not pruned when it should be")
    Stopping nodes
    Failed
    ```
    
    After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds.
    
    I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short.
    
    After changing the timeout to 30 seconds, the test passes consistently.
    (cherry picked from commit 3469911)
    error10 committed with MarcoFalke Dec 4, 2015
  5. @laanwj

    Merge #8028: Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteT…

    …oDisk
    
    
    0fd5997 Fix insanity of CWalletDB::WriteTx and CWalletTx::WriteToDisk (Patrick Strateman)
    laanwj committed May 10, 2016
  6. @laanwj

    Merge #8036: init: Move berkeleydb version reporting to wallet

    3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)
    laanwj committed May 10, 2016
  7. @laanwj

    init: Move berkeleydb version reporting to wallet

    Move the version reporting to Wallet::Verify, before starting
    verification of the wallet.
    
    This removes the dependency of init on a specific wallet database
    library.
    
    A further, trivial step towards resolving #7965.
    laanwj committed May 10, 2016
  8. @laanwj

    Merge #8019: Remove state arg from ReconsiderBlock, rename to ResetBl…

    …ockFailureFlags
    
    
    657e07e Rename ReconsiderBlock func to reflect real behavior (instagibbs)
    addb9d2 Remove state arg from ReconsiderBlock (instagibbs)
    laanwj committed May 10, 2016
  9. @laanwj

    Merge #8016: Fix multithread CScheduler and reenable test

    166e4b0 Notify other serviceQueue thread we are finished to prevent deadlocks. (Pavel Janík)
    db18ab2 Reenable multithread scheduler test. (Pavel Janík)
    laanwj committed May 10, 2016
  10. @jonasschnelli

    Merge #8012: Qt: Delay user confirmation of send

    3902a29 Qt: Delay user confirmation of send (Tyler Hardin)
    jonasschnelli committed May 10, 2016
  11. @fanquake
  12. @Tyler-Hardin

    Qt: Sort transactions by date

    Conflicted transactions can get stuck at the top. This fixes that.
    Tyler-Hardin committed May 9, 2016
  13. @Tyler-Hardin

    Qt: Delay user confirmation of send

    I made a subclass of QMessageBox that disables the send button in
    exec() and starts a timer that calls a slot to re-enable it after a
    configurable delay.
    
    It also has a countdown in the send/yes button while it is disabled
    to hint to the user why the send button is disabled (and that it is
    actually supposed to be disabled).
    Tyler-Hardin committed May 9, 2016
  14. @wtogami

    SOCKS5 connecting and connected messages with -debug=net.

    They were too noisy and not necessary for normal operation.
    wtogami committed May 9, 2016
  15. @wtogami

    Make failures to connect via Socks5() more informative and less unnec…

    …essarily scary.
    
    * The "ERROR" was printed far too often during normal operation for what was not an error.
    * Makes the Socks5() connect failure similar to the IP connect failure in debug.log.
    
    Before:
    `2016-05-09 00:15:00 ERROR: Proxy error: host unreachable`
    
    After:
    `2016-05-09 00:15:00 Socks5() connect to t6xj6wilh4ytvcs7.onion:18333 failed: host unreachable"`
    wtogami committed May 9, 2016
Commits on May 9, 2016
  1. @MarcoFalke
  2. @MarcoFalke
  3. @instagibbs
  4. @catilac

    fReopenDebugLog and fRequestShutdown should be type sig_atomic_t

    This allows access as an atomic variable in the presence
    of async interrupts.
    
    See issue #7433 for more details
    fixes: #7433
    catilac committed May 4, 2016
  5. @MarcoFalke

    Merge #7971: [qa] Refactor test_framework and pull tester

    fad3366 [qa] pull-tester: Adjust comment (MarcoFalke)
    fafb33c [qa] Stop other nodes, even when one fails to stop (MarcoFalke)
    2222dae [qa] Update README.md (MarcoFalke)
    fabbf6b [qa] Refactor test_framework and pull tester (MarcoFalke)
    MarcoFalke committed May 9, 2016
  6. @MarcoFalke

    Merge #8018: Autofind rpc tests --srcdir

    5ea4508 Autofind rpc tests --srcdir (Jonas Schnelli)
    MarcoFalke committed May 9, 2016
  7. @laanwj

    Merge #8030: test: Revert fatal-ness of missing python-zmq

    65fee8e test: Revert fatal-ness of missing python-zmq (Wladimir J. van der Laan)
    laanwj committed May 9, 2016
  8. @jonasschnelli
  9. @s-matthew-english

    changing "(tests are) automatically run" to correspond to the earlier…

    … instance of "run automatically (on the build server)"
    s-matthew-english committed May 9, 2016
  10. @laanwj

    Merge #7958: Remove useless argument to AlertNotify.

    b02119e Remove useless argument to AlertNotify. (Pavel Janík)
    laanwj committed May 9, 2016
  11. @laanwj

    test: Revert fatal-ness of missing python-zmq

    It looks like travis is using the `travis.yml` from the branch, but runs
    the test script from the branch merged into master. This causes
    pull requests created before the QA tests python 3 transition to fail.
    
    This temporarily reverts fa05e22
    (#7851). It can be restored when this is no longer an issue.
    laanwj committed May 9, 2016
  12. @laanwj

    Merge #7976: Remove obsolete reference to CValidationState from Updat…

    …eCoins.
    
    
    c8b9248 Remove obsolete reference to CValidationState from UpdateCoins. (21E14)
    laanwj committed May 9, 2016
  13. @pstratem
  14. @laanwj

    Merge #7934: Improve rolling bloom filter performance and benchmark

    1953c40 More efficient bitsliced rolling Bloom filter (Pieter Wuille)
    aa62b68 Benchmark rolling bloom filter (Pieter Wuille)
    laanwj committed May 9, 2016
Commits on May 8, 2016
  1. @MarcoFalke
Commits on May 6, 2016
  1. @paveljanik
  2. @paveljanik
  3. @instagibbs
  4. @laanwj

    Merge #8009: Docs: Fixed invalid example paths in gitian-building.md

    b06f6a9 Fixed invalid example paths in gitian-building.md (JeremyRand)
    laanwj committed May 6, 2016
  5. @laanwj

    Merge #8013: doc: Fedora build requirements, add gcc-c++ and fix typo

    b3d18ba doc: Fedora build requirements, add gcc-c++ and fix typo (Warren Togami)
    laanwj committed May 6, 2016
Something went wrong with that request. Please try again.