bitcoin/bitcoin

They're unused and produce nasty deprecation warnings

Github-Pull: #9786
Rebased-From: 3301587

Github-Pull: #9785
Rebased-From: c801c82

Github-Pull: #9785
Rebased-From: 914fad1

1577f07 Restore removed release notes. (Gregory Maxwell)

Generated from git, so there may be duplicate authors
if someone used multiple mail addresses.

…cache


42f5f21 release: bump gitian descriptors for a new 0.14 package cache (Cory Fields)

…i rescans


e662af3 Use 2 hour grace period for key timestamps in importmulti rescans (Russell Yanofsky)
38d3e9e [qa] Extend import-rescan.py to test imports on pruned nodes. (Russell Yanofsky)
c28583d [qa] Extend import-rescan.py to test specific key timestamps (Russell Yanofsky)
8be0866 [qa] Simplify import-rescan.py (Russell Yanofsky)

91fb506 Add two hour buffer to manual pruning (Alex Morcos)

3f78e46 Update nMinimumChainWork and defaultAssumeValid. (Gregory Maxwell)

55c403b Ensure `-maxsigcachesize` is in valid range (John Newbery)

- If the -maxsigcachesize parameter is set to zero, setup a minimum sized
sigcache (2 elements) rather than segfaulting.
- Handle maxsigcachesize being negative
- Handle maxsigcachesize being too large

Gregory Maxwell <greg@xiph.org> pointed out the lack of grace period in
#9490 (comment).

The importwallet RPC which uses key timestamps in a similar way already has a 2
hour grace period.

36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)

Get rid of partial functions so the test can be more easily extended to add
more variants of imports with options that affect rescanning (e.g. different
key timestamps).

Also change the second half of the test to send /to/ the imported addresses,
instead of /from/ the imported addresses. The goal of this part of the test was
to confirm that the wallet would pick up new transactions after an import
regardless of whether or not a rescan happened during the import. But because
the wallet can only do this reliably for incoming transactions and not outgoing
transactions (which require the wallet to look up transaction inputs) the test
previously was less meaningful than it should have been.

00e623d [Trivial] Update comments referencing main.cpp (CryptAxe)

…ssertion


07afcd6 Add missing cs_wallet lock that triggers new lock held assertion (Russell Yanofsky)

…marked 'override'" warnings


6c5427d wallet: Prevent "overrides a member function but is not marked 'override'" warnings (Wladimir J. van der Laan)

ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)

A new AssertLockHeld(cs_wallet) call was added in commit a58370e
"Dedup nTimeFirstKey update logic" (part of PR #9108).

The lock held assertion will fail when loading prexisting wallets files from
before the #9108 merge that have watch-only keys.

9acf25c Return error when importmulti called with invalid address. (Russell Yanofsky)

4b6cccc Selectively suppress deprecation warnings (Jonas Schnelli)

Fixes a bug in AcceptBlock() in invoking CheckBlock() with incorrect
arguments, and restores a call to CheckBlock() from ProcessNewBlock()
as belt-and-suspenders.

Updates the (overspecified) tests to match behavior.

…ide'" warnings

Because it is used inconsistently at least version 5.4.0 of g++ to
complains about methods that don't use override. There is two ways to go
about this: remove override from the methods having it, or add it to the
methods missing it. I chose the second.