Skip to content
Permalink
Branch: master
Commits on Oct 15, 2019
  1. Merge #17033: Disable _FORTIFY_SOURCE when enable-debug

    laanwj committed Oct 15, 2019
    44f7a8d Disable _FORTIFY_SOURCE when enable-debug (Andrew Chow)
    
    Pull request description:
    
      The `_FORTIFY_SOURCE` macro is enabled by default when hardening is enabled, but it requires optimization in order to be used. Since we disable all optimization with `--enable-debug`, this macro doesn't actually do anything and instead just causes a lot of warnings to be printed. This PR explicitly disables `_FORTIFY_SOURCE` so that these useless warnings aren't printed.
    
    ACKs for top commit:
      laanwj:
        Thanks. ACK 44f7a8d
    
    Tree-SHA512: e9302aef794dfd9ca9d0d032179ecc51d3212a9a0204454419f410011343b27c32e6be05f385051b5b594c607b91b8e0e588f644584d6684429a649a413077d9
  2. Merge #17086: tests: Fix fs_tests for unknown locales

    laanwj committed Oct 15, 2019
    d48f664 tests: Fix fs_tests for unknown locales (Daki Carnhof)
    
    Pull request description:
    
      Fix by removing "L" as suggested by meeDamian in
      #14948 (comment)
    
      ```
      # all in .../bitcoin/src/test
      $ uname -m
      x86_64
      $ export LC_ALL=randomnonexistentlocale
      $ ./test_bitcoin
      Running 369 test cases...
      unknown location(0): fatal error: in "fs_tests/fsbridge_fstream": boost::system::system_error: boost::filesystem::path codecvt to string: error
      test/fs_tests.cpp(13): last checkpoint: "fsbridge_fstream" test entry
    
      *** 1 failure is detected in the test module "Bitcoin Core Test Suite"
      ```
    
      After the patch is applied, the same test under the same conditions runs fine.
    
      ```
      $ export LC_ALL=randomnonexistentlocale
      $ ./test_bitcoin
      Running 369 test cases...
    
      *** No errors detected
      ```
    
      Co-Authored-By: bugs@meedamian.com
    
    ACKs for top commit:
      laanwj:
        ACK d48f664
    
    Tree-SHA512: a9910252b8ce6a05cab5530874549c2999ca2c28e835fc18aa8e5468fb417bd7d245864ec71d9233dd53e02940a9f0691b247430257f27eb0d7c20745d1c846d
  3. Merge #17111: doc: update bips.md with buried BIP9 deployments

    laanwj committed Oct 15, 2019
    fa6ed82 doc: update bips.md with buried BIP9 deployments (MarcoFalke)
    
    Pull request description:
    
      Also, remove the activation heights, as they can be retrieved from `./src/chainparams.cpp` (if needed)
    
    ACKs for top commit:
      laanwj:
        ACK fa6ed82, needs backport to 0.19 I guess.
    
    Tree-SHA512: 9c069cc14589a3e2309d76f042677c024a9e14d16dbfccef54c4a2963ca7853d01f042b0237e346538c557591b7553deed9dd811ba64bbd0ced88883d562c59a
  4. github: Add warning for bug reports

    laanwj committed Oct 15, 2019
    I've noticed the "Bug" label being added redundantly fairly frequently.
    I think this might be due to github's templates.
    
    All in all, the link in https://github.com/bitcoin/bitcoin/issues/new/choose
    to open a regular issue is a bit hidden from sight. Direct people's
    attention to it.
Commits on Oct 14, 2019
  1. Merge #17057: build: switch to upstream libdmg-hfsplus

    laanwj committed Oct 14, 2019
    9192ce5 depends: pull upstream libdmg-hfsplus changes (fanquake)
    9b54f34 depends: latest config.guess & config.sub (fanquake)
    
    Pull request description:
    
      Pulled the first two commits off #16392, as they are standalone.
    
      Corys PRs (planetbeing/libdmg-hfsplus#7, planetbeing/libdmg-hfsplus#8) have been merged, and the author was active for a little while in 2017/18, so switch back to the upstream [`libdmg-hfsplus`](https://github.com/planetbeing/libdmg-hfsplus) repo. I've added the last of Corys patches into depends.
    
      [Switching back to upstream discussion](#16392 (comment)).
    
    Top commit has no ACKs.
    
    Tree-SHA512: a2313a731242251fef28921faf403c9bc354e6271cd7a26e9904ff5fae5766678136697fb5696006498a982ce319747b52b1df5151837388cda8f8145b45ab7c
Commits on Oct 10, 2019
  1. Merge #17085: init: Change fallback locale to C.UTF-8

    laanwj committed Oct 10, 2019
    facb9a1 init: Change fallback locale to C.UTF-8 (Wladimir J. van der Laan)
    
    Pull request description:
    
      Much of our code assumes file system UTF-8 support, and this is a more realistic guess for modern systems anyway than the default character set (which would be ASCII only). So change the assumed fallback locale (if no locale is defined by the user or OS) to `C.UTF-8`.
    
      related: #14948 (comment)
    
    ACKs for top commit:
      MarcoFalke:
        ACK facb9a1
    
    Tree-SHA512: 5075f9fe6791572d76ec38c58cd56f04ed8086c06a7d7f446d062dffc313c62466ba81f1a7d6b8c7e95791fcff82e4f76871c3534478fbfe5beb456dd8eea340
Commits on Oct 9, 2019
  1. Merge #17084: build: Fix #include sys/poll.h to just poll.h (without …

    laanwj committed Oct 9, 2019
    …sys/)
    
    4de0bde build: Fix #include sys/poll.h to just poll.h (without sys/) (Daki Carnhof)
    
    Pull request description:
    
      http://pubs.opengroup.org/onlinepubs/009695399/functions/poll.html
      http://man7.org/linux/man-pages/man2/poll.2.html
    
    ACKs for top commit:
      Empact:
        ACK 4de0bde
    
    Tree-SHA512: 01c22a62b5bc327b3a46f721312af2283f4e09cb314bc7a3f82dbc1f4eda6f018a394559c4370fee895532e768b8a9152783979d61cb8a0ed86de069f7c150fb
  2. init: Change fallback locale to C.UTF-8

    laanwj committed Oct 9, 2019
    Much of our code assumes UTF-8 support, and this is a more realistic
    guess for modern systems anyway than the default character set (which
    would be ASCII only). So change the assumed fallback locale (if no
    locale is defined by the user or OS) to `C.UTF-8`.
  3. Merge #15437: p2p: Remove BIP61 reject messages

    laanwj committed Oct 9, 2019
    fa25f43 p2p: Remove BIP61 reject messages (MarcoFalke)
    
    Pull request description:
    
      Reject messages (BIP 61) appear in the following settings:
    
      * Parsing of reject messages (in case `-debug=net` is set, off by default). This has only been used for a single `LogPrint` call for several releases now. Such logging is completely meaningless to us and should thus be removed.
    
      * The sending of reject messages (in case `-enablebip61` is set, off by default). This can be used to debug a node that is under our control. Instead of hacking this debugging into the p2p protocol, it could be more easily achieved by parsing the debug log. (Use `-printtoconsole` to have it as stream, or read from the `debug.log` file like our python function `assert_debug_log` in the test framework does)
    
      Having to maintain all of this logic and code to accommodate debugging, which can be achieved by other means a lot easier, is a burden. It makes review on net processing changes a lot harder, since the reject message logic has to be carried around without introducing any errors or DOS vectors.
    
    ACKs for top commit:
      jnewbery:
        utACK fa25f43
      laanwj:
        I'm still not 100% convinced that I like getting rid of BIP61 conceptually, but apparently everyone wants it, code review ACK fa25f43.
      ryanofsky:
        Code review ACK fa25f43
    
    Tree-SHA512: daf55254202925e56be3d6cfb3c1c804e7a82cecb1dd1e5bd7b472bae989fd68ac4f21ec53fc46751353056fd645f7f877bebcb0b40920257991423a3d99e0be
  4. Merge #17074: build: Added double quotes

    laanwj committed Oct 9, 2019
    dd85166 Added double quotes (Ava Barron)
    
    Pull request description:
    
      Added double quotes to prevent globbing and word splitting.
    
    ACKs for top commit:
      laanwj:
        ~~ACK dd85166~~
      practicalswift:
        ACK dd85166 -- diff looks correct
      hebasto:
        ACK dd85166, tested locally on Linux Mint 19.2.
    
    Tree-SHA512: 503ed8c4a5dafd3868465fbb66b13e15862c114573609f681b69259703e76fe85260b782c45a1e0780b7d3fdf34d8fd2f627b59f4013b99eeb1b771a652e7b10
  5. Merge #17029: gitian: Various improvements for Windows descriptor

    laanwj committed Oct 9, 2019
    9d1f971 gitian: Put things in the right place to begin with (Carl Dong)
    71949a9 gitian: Eliminate rename dependency (Carl Dong)
    999a9a5 gitian: Smaller diff with gitian-linux.yml (Carl Dong)
    c4a3c25 gitian: Fix README inclusion in archives (Carl Dong)
    93cb974 gitian: Use split-debug.sh for Win builds (Carl Dong)
    
    Pull request description:
    
      It would seem that our `gitian-win.yml` has not been keeping up with `gitian-linux.yml`, this PR:
    
      1. Minimizes the diff size between `gitian-{win,linux}.yml`
      2. Eliminates the `rename` dependency
    
    ACKs for top commit:
      laanwj:
        ACK 9d1f971
    
    Tree-SHA512: 84ed47c685e12d0064c02811907ae3d0fd3c47db8773d497dcc38f0defbfb3040fd82899fb026cf355f229b906d05a1c8038a95642bb90d044afbc2e0b239af2
Commits on Oct 8, 2019
  1. Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make trans…

    laanwj committed Oct 8, 2019
    …late`
    
    c640ca2 Always generate `bitcoinstrings.cpp` on `make translate` (Franck Royer)
    
    Pull request description:
    
      Resolves #16891.
    
      `bitcoinstrings.cpp` is to be generated at release time. Hence,
      it should not depend on whether the source files are younger as the
      releaser may proceed from a fresh checkout.
    
      More information on the investigation in the issue.
    
    ACKs for top commit:
      jonasschnelli:
        Tested ACK c640ca2 - Tested master + this on macOS 10.14. With this PR, it always "runs" `GEN      qt/bitcoinstrings.cpp` and `GEN      translate`.
    
    Tree-SHA512: f799fdc3ad16a2a6a59704bc2c50f5179e6a7e064d8f43354592f11857cc901cac99b2b90f3319d25d49c9d78378b8d119cc5f59b48ea7f1008f33dd26700877
  2. Merge #17066: build: Remove workaround for ancient libtool

    laanwj committed Oct 8, 2019
    30fc1a3 build: Remove workaround for ancient libtool (Hennadii Stepanov)
    6ca01b9 build: Ensure a minimal version of libtool (Hennadii Stepanov)
    
    Pull request description:
    
      Since libtool 1.5.2, on Linux libtool no longer sets RPATH for any directories in the dynamic linker search path, so there is no longer an issue.
    
      This commit reverts a98356f.
    
      Refs:
      - https://wiki.debian.org/RpathIssue
      - [Debian jessie has libtool 2.4.2](https://packages.debian.org/jessie/libtool)
    
    ACKs for top commit:
      laanwj:
        ACK 30fc1a3
    
    Tree-SHA512: fab56265d4d2c96216a353cc076c6f510e15748d8134f97bae2f67b6d8c0b6a1a9f362d2ab23b19ccc3a8bba8eac3bb1668fc3e42037590f63a7ab4819c9ee15
  3. Merge #17059: util: Simplify path argument for CBlockTreeDB ctor

    laanwj committed Oct 8, 2019
    c2bb391 util: Simplify path argument for CBlockTreeDB ctor (Hennadii Stepanov)
    
    Pull request description:
    
      This PR:
      - simplifies path argument (`datadir/blocks/index`) for `CBlockTreeDB`  constructor
      - does not change behavior as `GetBlocksDir()` with unset "-blocksdir" returns the same path
      - improves code readability
    
    ACKs for top commit:
      MarcoFalke:
        ACK c2bb391
      laanwj:
        ACK c2bb391
      promag:
        ACK c2bb391.
    
    Tree-SHA512: 646a0a3a31e2f419b05f696cbdfb7d8987f1d89ec0797b72464ae05680fd5f95f6469be0ea5b56f772434c49d48504cd9cf9760c05d4054d11349d502e157ee2
  4. Merge #16569: Increase init file stop timeout

    laanwj committed Oct 8, 2019
    7fb7acf Set init stop timeout to 10 min (setpill)
    
    Pull request description:
    
      `bitcoind` can take a long time to flush its db cache to disk upon
      shutdown. Systemd sends a `SIGKILL` after a timeout, causing unclean
      shutdowns and triggering a long "Rolling forward" at the next startup.
      Disabling the timeout should prevent this from happening, and does not
      break systemd's `restart` logic.
    
      Addresses #13736.
    
    ACKs for top commit:
      instagibbs:
        utACK 7fb7acf
    
    Tree-SHA512: 16e0ce5a9ecf0628f8d93d68db3f5a78ab36021d9bede05a90c84f144db2e87e17707a6eb910cb7c018c265ce2c81d43de2988bd79e4a2d8554515db8fb5aa36
  5. Merge #17011: ci: Use busybox utils for one build

    laanwj committed Oct 8, 2019
    ddddd89 ci: Use busybox utils for one build (MarcoFalke)
    
    Pull request description:
    
      To make sure Bitcoin Core can be built with BusyBox, see #16927 (comment)
    
    ACKs for top commit:
      laanwj:
        ACK ddddd89
    
    Tree-SHA512: da3a4654ee7975206d04643675d309b4973a510ca344acaec97fb1ed19c43cf13489bdf236c92c4a90499ec5b3c18c3338fff096110b26abee5ffe955089f267
  6. Merge #17073: move-only: PASTE macros to util/macros.h

    laanwj committed Oct 8, 2019
    0d86f4d refactor: consolidate PASTE macros (James O'Beirne)
    
    Pull request description:
    
      Really dumb move-only stolen from #16805. Some of my pull requests also depend on this, so I split it up to not depend on #16805.
    
    ACKs for top commit:
      practicalswift:
        ACK 0d86f4d -- diff looks correct
      hebasto:
        ACK 0d86f4d, I have reviewed the code and it looks OK, I agree it can be merged.
      promag:
        ACK 0d86f4d.
    
    Tree-SHA512: 19208a8cbf83034b1ef25138d8f08d8f32ace7775f654b1597fc4599dd576f0758145f592f161cfdcaaa29d4907ac9aa5553f6f524e2b960205c760605a05901
  7. Merge #16802: scripts: In linearize, search for next position of magi…

    laanwj committed Oct 8, 2019
    …c bytes rather than fail
    
    3284e6c scripts: search for next position of magic bytes rather than fail (Tim Akinbo)
    
    Pull request description:
    
      When using the `linearize-data.py` contrib script to export block data, there are edge cases where the script fails with an `Invalid magic: 00000000` error. This error occurs due to the presence of padding bytes that occasionally appears between consecutive blocks in the block data file.
    
      There's an ongoing conversation about this in #14986. sipa also admitted that it is a bug in #5028. Fortunately, this is not an issue in bitcoin core as it handles this type of situation gracefully and so no fix in bitcoin core is required.
    
      This PR is an improvement on how the script handles these "invalid magic bytes". Rather than failing, this patch allows the script to search for the next occurrence of the magic bytes and then starts reading the block from there.
    
    ACKs for top commit:
      laanwj:
        ACK 3284e6c
    
    Tree-SHA512: 18067ae0b4b62e822dfc558a86439ad6acaf939b98479e38e8e4248536574643b26eb48e96ec7139375c88b42cbe7705a64deb13a3c239e16025a6aad3d69bfa
  8. Merge #17030: test: Fix Python Docstring to include all Args.

    laanwj committed Oct 8, 2019
    8acd589 Fix Python Docstring to include all Args. (John Bampton)
    
    Pull request description:
    
      Found a Python function that had incorrect and missing arguments in its Docstring.
    
    ACKs for top commit:
      laanwj:
        ACK 8acd589
    
    Tree-SHA512: 936f275f29a700d630bb479b5283e47b66f2df76d8b8c053f594e6aedf783cc98a29c924c3a46613f112dfc884acb50f21a0b18f96d939e887b12b921ef2e10f
Commits on Oct 3, 2019
  1. Merge #17022: doc: move-only: Steps for "before major release branch-…

    laanwj committed Oct 3, 2019
    …off"
    
    faca1c2 doc: move-only: Steps for "before major release branch-off" (MarcoFalke)
    
    Pull request description:
    
      The chainparams are updated before branch-off, so that the master branch has the bumped values as well
    
    ACKs for top commit:
      laanwj:
        ACK faca1c2
    
    Tree-SHA512: ffc3ea49f0f6dc64dd9bea958e12ebc058496291c1c06d02994b3bf1751602e7c5000fd5eda166fcdbf9ba6d593e19731e93342dd8f2fe410f656a798bef459c
  2. Merge #17038: Don't rename main thread at process level

    laanwj committed Oct 3, 2019
    07e4bdb Don't rename main thread at process level (Wladimir J. van der Laan)
    
    Pull request description:
    
      Set only the internal name for the main threads.
    
      Fixes #17036 for both `bitcoind` and `bitcoin-qt`.
    
      After this, e.g. `killall` works again for either.
    
    ACKs for top commit:
      promag:
        Tested ACK 07e4bdb, `killall bitcoind` and `killall bitcoin-qt` now just works!
      jonatack:
        ACK 07e4bdb `killall bitcoind` shuts down bitcoind mainnet/testnet/regtest, `killall bitcoin-qt` shuts down `./src/qt/bitcoin-qt`, tests pass, very light code review. Good idea to add the `@note` warning. Thanks!
    
    Tree-SHA512: 8f310ae646c83a02de7cc6869aa9aca1d53613d8fb762d05e3dfa52e17ca82abeb99044564cf7ba45b3c4b320e65bf8315d0e8834a9e696f097be5af638c6fd9
  3. Don't rename main thread at process level

    laanwj committed Oct 3, 2019
    Set only the internal name.
    
    Fixes #17036 for both `bitcoind` and `bitcoin-qt`.
Commits on Oct 2, 2019
  1. Merge #13716: bitcoin-cli: -stdinwalletpassphrase and non-echo stdin …

    laanwj committed Oct 2, 2019
    …passwords
    
    50c4afa add newline after -stdin* (Karl-Johan Alm)
    7f11fba cli: add -stdinwalletpassphrase for (slightly more) secure CLI (Karl-Johan Alm)
    0da503e add stdin helpers for password input support (Karl-Johan Alm)
    
    Pull request description:
    
      This PR
      * adds `-stdinwalletpassphrase` for use with `walletpasshprase(change)`
      * adds no-echo for passwords (`-stdinrpcpass` and above)
    
      It may not be ideal, but it's better than having to clear the screen whenever you unlock the wallet.
    
    ACKs for top commit:
      laanwj:
        code review ACK 50c4afa
    
    Tree-SHA512: 473db8a303ff360ffaa36ac81a2f82be2136fa82696df0bc4f33cb44033a3ae258b5aa5bbcc1f101f88ae9abe9598ed564ce52877ab139bd5d709833f5275ec6
  2. Merge #16884: wallet: Change default address type to bech32

    laanwj committed Oct 2, 2019
    71d4edd Add release note for bech32 by default in wallet (Gregory Sanders)
    b34f018 Revert "gui: Generate bech32 addresses by default (take 2, fixup)" (Gregory Sanders)
    f50785a Change default address type to bech32 (Gregory Sanders)
    
    Pull request description:
    
    ACKs for top commit:
      MarcoFalke:
        re-ACK 71d4edd (only change is restore mimick behavior)
      laanwj:
        ACK 71d4edd
    
    Tree-SHA512: 3c49a1b51c49f3a762ad08985167ca1b89b0177ae20ab6d5883f1f74dde7a155921c1b855a842199bbf32f563c56b33f8b603bc842637bdcb121001023d454b6
  3. Merge #16908: txmempool: Make entry time type-safe (std::chrono)

    laanwj committed Oct 2, 2019
    faec689 txmempool: Make entry time type-safe (std::chrono) (MarcoFalke)
    faaa1f0 util: Add count_seconds time helper (MarcoFalke)
    1111170 test: mempool entry time is persisted (MarcoFalke)
    
    Pull request description:
    
      This changes the type of the entry time of txs into the mempool from `int64_t` to `std::chrono::seconds`.
    
      The benefits:
      * Documents the type for developers
      * Type violations result in compile errors
      * After compilation, the two are equivalent (at no run time cost)
    
    ACKs for top commit:
      ajtowns:
        utACK faec689
      laanwj:
        ACK faec689
    
    Tree-SHA512: d958e058755d1a1d54cef536a8b30a11cc502b7df0d6ecf84a0ab1d38bc8105a67668a99cd5087a444f6de2421238111c5fca133cdf8e2e2273cb12cb6957845
  4. Merge #17007: build: 0.19 release updates on master

    laanwj committed Oct 2, 2019
    4341018 doc: reset release notes after 0.19 split-off (Jon Atack)
    c0859b7 build: 0.19 release updates on master (Jon Atack)
    
    Pull request description:
    
      Post split-off. As per https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-major-release and  issue #16996.
    
      Note: after split-off, the same changes should be made on the new 0.19.0 release branch, with also these additional changes to both files (configure.ac and build_msvc/bitcoin_config.h):
    
        - set `CLIENT_VERSION_REVISION` to `0`
        - set `CLIENT_VERSION_IS_RELEASE` to `true`
    
      The second commit resets the release notes after branch-off and proposes a few improvements.
    
    ACKs for top commit:
      laanwj:
        ACK 4341018
    
    Tree-SHA512: 5a6afeb9cff6fa827865894cc7d3dc789db1c8b5d875ba49fdcfd9fd48af9d2d2864f49a992988136425744af74053cb57a4a92a1665a09b194eecb1a2972315
  5. Merge #16727: wallet: Explicit feerate for bumpfee

    laanwj committed Oct 2, 2019
    c812aba test bumpfee fee_rate argument (ezegom)
    9f25de3 rpc bumpfee check fee_rate argument (ezegom)
    88e5f99 rpc bumpfee: add fee_rate argument (ezegom)
    1a4c791 rpc bumpfee: move feerate estimation logic into separate method (ezegom)
    
    Pull request description:
    
      Taking over for #16492 which seems to have gone inactive.
    
      Only minor commit cleanups, rebase, and some help text fixes on top of previous PR. Renamed `feeRate` to `fee_rate` to reflect updated guidelines.
    
    ACKs for top commit:
      Sjors:
        Code review ACK c812aba
      laanwj:
        ACK c812aba
    
    Tree-SHA512: 5f7f51bd780a573ccef1ccd72b0faf3e5d143f6551060a667560c5163f7d9480e17e73775d1d7bcac0463f3b6b4328f0cff7b27e39483bddc42a530f4583ce30
  6. Merge #16952: gui: make sure to update the UI when deleting a transac…

    laanwj committed Oct 2, 2019
    …tion
    
    addaf8a make sure to update the UI when deleting a transaction (Jonas Schnelli)
    
    Pull request description:
    
      `CWallet::ZapSelectTx` removes transactions from the internal model, but leaves the UI in the dark.
      Adding a `NotifyTransactionChanged()` should avoid having invalid transactions in the GUI.
    
      Fixes #16950
    
    ACKs for top commit:
      fanquake:
        ACK addaf8a - tested that this fixes #16950
      Sjors:
        tACK addaf8a: tested with an unpruned wallet by calling `removeprunedfunds` on an RBF-replaced transaction. It neatly disappears from the UI.
      kristapsk:
        ACK addaf8a (tested both with and without this change)
    
    Tree-SHA512: 65e8c690847f7499e82c9fef67b60d9aaa63c853732fe7fa7281da33054fcdcd9d24f5b86de71b0827728c25bac8efb7db445863f990304ebfee6fc450620c47
  7. Merge #16849: Fix block index inconsistency in InvalidateBlock()

    laanwj committed Oct 2, 2019
    2a4e60b Fix block index inconsistency in InvalidateBlock() (Suhas Daftuar)
    
    Pull request description:
    
      Previously, we could release `cs_main` while leaving the block index in a state
      that would fail `CheckBlockIndex()`, because `setBlockIndexCandidates` was not being
      fully populated before releasing `cs_main`.
    
    ACKs for top commit:
      TheBlueMatt:
        utACK 2a4e60b. I also discovered another issue in InvalidateBlock while reviewing, see #16856.
      Sjors:
        ACK 2a4e60b. Tested on top of #16899. Also tested `invalidateblock` with `-checkblockindex=1`.
      fjahr:
        ACK 2a4e60b. Ran tests, reviewed code, inspected behavior while manually testing `invalidateblock`.
    
    Tree-SHA512: ced12f9dfff0d413258c709921543fb154789898165590b30d1ee0cdc72863382f189744f7669a7c924d3689a1cc623efdf4e5ae3efc60054572c1e6826de612
  8. Merge #16999: net: 0.19 seeds update

    laanwj committed Oct 2, 2019
    0218171 contrib: Remove invalid nodes from seeds list (Wladimir J. van der Laan)
    3b09f2b net: 0.19 hardcoded seeds update (Wladimir J. van der Laan)
    801d341 contrib: makeseeds: More fancy output (Wladimir J. van der Laan)
    ed76299 contrib: makeseeds: Limit per network, instead of total (Wladimir J. van der Laan)
    c254a9e contrib: makeseeds: dedup by ip,port (Wladimir J. van der Laan)
    3314d87 contrib: makeseeds: Factor out ASN lookup (Wladimir J. van der Laan)
    301c2b1 contrib: makeseeds: Improve logging and filtering (Wladimir J. van der Laan)
    
    Pull request description:
    
      - contrib: Improve makeseeds script
      - net: 0.19 hardcoded seeds update
    
      Sources:
      - http://bitcoin.sipa.be/seeds.txt.gz (Sipa)
      - https://github.com/bitcoin/bitcoin/files/3671913/dnsseed.dump.tar.gz (Sjors)
    
      Output:
      ```
      Initial: IPv4 418690, IPv6 55861, Onion 2747
      Skip entries with invalid address: IPv4 418690, IPv6 55861, Onion 2747
      After removing duplicates: IPv4 409220, IPv6 54028, Onion 2717
      Skip entries from suspicious hosts: IPv4 409219, IPv6 54028, Onion 2717
      Enforce minimal number of blocks: IPv4 106719, IPv6 46342, Onion 2621
      Require service bit 1: IPv4 106384, IPv6 46241, Onion 2542
      Require minimum uptime: IPv4 5300, IPv6 1153, Onion 201
      Require a known and recent user agent: IPv4 4642, IPv6 1060, Onion 141
      Filter out hosts with multiple bitcoin ports: IPv4 4642, IPv6 1060, Onion 141
      Look up ASNs and limit results, both per ASN and globally: IPv4 464, IPv6 48, Onion 141
      ```
    
    ACKs for top commit:
      Sjors:
        ACK 0218171. I also checked that `chainparamsseeds.h` is generated from `nodes_main.txt`. Sounds like we should look at this script a bit more outside release moments :-)
    
    Tree-SHA512: c1f5795fe88d14800c4da918387368d51e85f4319f2ce3c0359851d041767e2883f32b1da371bba22bd5f0b442ac3e5ea7d685c233ad2cc4045c930f973b0aa2
  9. Merge #13266: refactor: privatize SignatureExtractorChecker [moveonly]

    laanwj committed Oct 2, 2019
    73aaf4e Make SignatureExtractorChecker private to its own file (Ben Woosley)
    
    Pull request description:
    
      ~If we add a CTxIn constructor to SignatureData, then constructing the
      SignatureData directly is no more verbose than calling DataFromTransaction,
      and grants the caller additional flexibiliy in how to provide the CTxIn.~
    
      A simple change to enhance encapsulation.
    
    ACKs for top commit:
      MarcoFalke:
        utACK 73aaf4e
      laanwj:
        ACK 73aaf4e
    
    Tree-SHA512: f7eafbce22b0e9917a8487e88d1f5a1061f2a0959ae1a097cbd9c8ea0d774edfb807da56813cb5fb26f6ca98499a0604a8ff024c198a7c8dc755164de66d972a
  10. contrib: Remove invalid nodes from seeds list

    laanwj committed Oct 2, 2019
Commits on Oct 1, 2019
  1. Merge #17001: doc: Remove mention of renamed mapBlocksUnlinked

    laanwj committed Oct 1, 2019
    fadd6e0 doc: Remove mention of renamed mapBlocksUnlinked (MarcoFalke)
    
    Pull request description:
    
      This has been renamed to `m_blocks_unlinked`. Instead of adjusting the internal variable name in the help text, explain the debug flag with more general terms.
    
    ACKs for top commit:
      practicalswift:
        ACK fadd6e0 -- diff looks correct
      promag:
        ACK fadd6e0.
      laanwj:
        ACK fadd6e0 (as argument help is not translated this doesn't have to wait for the split-off)
    
    Tree-SHA512: 8ad64965ab5bbba4b92933a5adcb0c9eda5bdb0cc080840a4a97b12c67f41f9b789fd289df4932d748f5a7eebc7305a000f03ceb968a78c9b5d9f34af61f0b15
  2. Merge #16852: gui: When BIP70 is disabled, get PaymentRequest merchan…

    laanwj committed Oct 1, 2019
    …t using string search
    
    85973bc When BIP70 is disabled, get PaymentRequest merchant using string search (Andrew Chow)
    
    Pull request description:
    
      The merchant name is stored in the X.509 certificate embedded in a PaymentRequest. Use some string searching to locate it so that it can be shown to the user in the transaction details when BIP70 support was not configured.
    
      An additional notice is added to the merchant string that indicates the certificate was not verified. When BIP70 is enabled, the certificate would be verified and the merchant name not shown if the certificate was invalid.
    
    ACKs for top commit:
      laanwj:
        ACK 85973bc
    
    Tree-SHA512: 50fdb60d418e2f9eb65a4b52477be16189f00bfc30493adb27d9fb62100fd5bca33b98b8db6caa8485db424838d3b7a1da802c14ff4917943464401f47391616
  3. net: 0.19 hardcoded seeds update

    laanwj committed Sep 30, 2019
Older
You can’t perform that action at this time.