Automated testing of mappings in RPC server registration and client arg conversion

[TheBlueMatt]

#10747 fixed an issue where out client-side args type conversions got de-synced from our server-side named arguments -> arg position mappings. It would be super nice to have some kind of automated tester for that as I'm afraid simple typos will go entirely unnoticed.

[luke-jr]

I agree. But I wonder if it's possible to just use the main RPC arg list rather than having two mapping lists?

[TheBlueMatt]

I thought about that, might lead to having much too many deps for -cli, but we could maybe go the other way - have a separate table for name -> arg mappings and use that.

…

On July 5, 2017 6:46:43 PM EDT, Luke Dashjr ***@***.***> wrote: I agree. But I wonder if it's possible to just use the main RPC arg list rather than having two mapping lists?

[laanwj]

I actually have a script for this, just need to hook it in (and update it for the new "a|b" syntax).

I agree. But I wonder if it's possible to just use the main RPC arg list rather than having two mapping lists?

The problem is indeed one of dependencies. There is no way the -cli can access the server implementation files (rpc/misc.cpp etc). which contain the dispatch tables.

An old idea is to remove all command-specific knowledge from the cli and instead request a JSON document from the server that describes the interface. This, in combination with smart caching to prevent extra roundtrips, could work.