Skip to content

code to "request last block in an inv bundle (even if we already have it)" does not work. #1185

Closed
rebroad opened this Issue May 2, 2012 · 4 comments

3 participants

@rebroad
rebroad commented May 2, 2012

in main.cpp, there is a section that adds to the "askfor" queue a block where AlreadyHave() returns true. Then later when the code retrieves the queue, it erases it without actioning it due to AlreadyHave() returning true.

Which bit of code is incorrect? The adding to the queue part, or the actioning the queue part?

@sipa
Bitcoin member
sipa commented May 3, 2012

You can make comments inside the actual code. I'm not sure which part you're talking about now.

@rebroad
rebroad commented May 3, 2012

ah.. good idea... using github? do I need to find the commit that added the code first?

(by the way, my bitcoin is still reporting 0.6.0rc4, even though I've merged with the latest master - any idea how to get it to use the correct tag please? - sorry for asking in here - no forum access)

@Diapolo
Diapolo commented May 3, 2012

That's how you can link (this is line 2 in main.cpp from current master):
https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L2

@rebroad
rebroad commented May 4, 2012

@sipa, the commit in question that introduced the code (which I maintain doesn't do what it says it does) is this: 0aa89c0

@rebroad rebroad closed this Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.