Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listsinceblock shows conflicted transactions forever #11853

Open
TheBlueMatt opened this issue Dec 8, 2017 · 0 comments
Open

listsinceblock shows conflicted transactions forever #11853

TheBlueMatt opened this issue Dec 8, 2017 · 0 comments

Comments

@TheBlueMatt
Copy link
Contributor

@TheBlueMatt TheBlueMatt commented Dec 8, 2017

Because listsinceblock walks mapWallet and checks only that GetDepthInMainChain() < the depth of the block requested, conflicted transactions (which have negative GetDepthInMainChain()) may be repeatedly included in output forever. This should (hopefully) not break any usage of the API, but some folks appear to rely on listsinceblock not returning things repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.