Infinite recursion when using -debug and DEBUG_LOCKORDER #1213

Closed
TheBlueMatt opened this Issue May 6, 2012 · 7 comments

Comments

Projects
None yet
4 participants
@TheBlueMatt
Contributor

TheBlueMatt commented May 6, 2012

push_lock -> printf -> OutputDebugStringF -> GetDataDir -> LOCK -> push_lock

@gavinandresen

This comment has been minimized.

Show comment Hide comment
@gavinandresen

gavinandresen May 7, 2012

Contributor

LOCK inside OutputDebugStringF or any of the routines it calls is a big no-no...

Contributor

gavinandresen commented May 7, 2012

LOCK inside OutputDebugStringF or any of the routines it calls is a big no-no...

@sipa

This comment has been minimized.

Show comment Hide comment
@sipa

sipa May 7, 2012

Owner

GetDataDir should not lock, except the first time it is called

Owner

sipa commented May 7, 2012

GetDataDir should not lock, except the first time it is called

@TheBlueMatt

This comment has been minimized.

Show comment Hide comment
@TheBlueMatt

TheBlueMatt May 7, 2012

Contributor

You could reasonably just remove the lock, GetDataDir is called a few times before any other threads are started, so its pretty safe, but I probably missed an edge case or two.

Contributor

TheBlueMatt commented May 7, 2012

You could reasonably just remove the lock, GetDataDir is called a few times before any other threads are started, so its pretty safe, but I probably missed an edge case or two.

@sipa

This comment has been minimized.

Show comment Hide comment
@sipa

sipa May 7, 2012

Owner

Or make sure it's called once beforehand?

Owner

sipa commented May 7, 2012

Or make sure it's called once beforehand?

@TheBlueMatt

This comment has been minimized.

Show comment Hide comment
@TheBlueMatt

TheBlueMatt May 7, 2012

Contributor

Simple enough either way.

Contributor

TheBlueMatt commented May 7, 2012

Simple enough either way.

@laanwj

This comment has been minimized.

Show comment Hide comment
@laanwj

laanwj Mar 29, 2013

Owner

Is this still the case?

Owner

laanwj commented Mar 29, 2013

Is this still the case?

@laanwj laanwj added the Tests label Jul 31, 2014

@sipa

This comment has been minimized.

Show comment Hide comment
@sipa

sipa Aug 3, 2014

Owner

I believe this code was significantly changed since.

Owner

sipa commented Aug 3, 2014

I believe this code was significantly changed since.

@laanwj laanwj closed this Feb 9, 2016

suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this issue Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment