Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[RFC] Long term plan for wallet command-line args #13044
The wallet command line arguments are a mixture of start-up actions, wallet creation options, updatable wallet parameters and wallet module modes. This is a proposal on how to rationalize the different types of arguments.
Current wallet arguments
These can be categorised as follows:
Wallet module options
These act on the wallet software module, not on individual wallets:
Wallet creation options
Currently none, but these options have been proposed in PRs:
Prior to V0.16:
Wallet startup actions
These act on an individual wallet at node startup (cannot currently be used in multiwallet mode)
Wallet config options
These are all currently treated as global wallet module options, but logically should be per-wallet config:
This is treated as per-wallet config, but there is currently no way to specify different config for different wallets at startup:
Yes - good point. We should remove the
There's interaction between
referenced this issue
Jul 30, 2018
Agree with moving these to a separate tool #13926. I'm assuming here that nobody uses these commands in an automated environment, so we're not breaking anyones setup by just removing this from
Also agree that
We could add
Once #11082 is merged, it should be easy to update wallet-specific settings in config files, rather than in the payload (though I'm not fully convinced storing settings in the payload is bad).
I do wonder if
In general I'd really like to avoid having a given setting both global and with wallet specific overrides.
If we add descriptor support to wallets, and assuming new wallets won't use
The keypool might disappear altogether, so that could remain a global option for pre-descriptor wallets.
keypool is both a "wallet startup action" and "wallet config option". You are saying to move those to the RPCs (such as
My preference would be for bitcoind to never create a wallet on startup. This has been suggested a few times on IRC, for example, here: http://www.erisian.com.au/bitcoin-core-dev/log-2018-12-20.html#l-243.
The wallet tool can easily be extended to take arguments for settings like
I agree about not creating a wallet on startup. For RPC users, if they call any command such as