Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: Unlock spent outputs #13160

Merged
merged 2 commits into from Jun 24, 2018
Merged

wallet: Unlock spent outputs #13160

merged 2 commits into from Jun 24, 2018

Conversation

promag
Copy link
Member

@promag promag commented May 3, 2018

Fixes #12738.

@laanwj
Copy link
Member

laanwj commented May 3, 2018

Concept ACK

@maflcko
Copy link
Member

maflcko commented May 3, 2018

How is this different from #12739?

@promag
Copy link
Member Author

promag commented May 3, 2018 •
edited

That one allows to unlock the already spent output via RPC (IMO lockunspent should only work for unspent outputs).

This one automatically removes the output from the locked set when the output is spent.

@laanwj
Copy link
Member

laanwj commented May 14, 2018

I have a slight preference for this one. I don't think spent outputs should stay in the 'locked' list.

@maflcko maflcko changed the title Unlock spent outputs wallet: Unlock spent outputs May 14, 2018
@promag promag force-pushed the 2018-05-unlock-spent-output branch from 6732dbe to fd9b3a7 Compare May 25, 2018 13:29
@laanwj
Copy link
Member

laanwj commented May 29, 2018

utACK fd9b3a7

tecnovert added a commit to particl/particl-core that referenced this pull request May 31, 2018
@tecnovert
Add permanent option to lockunspent.
606ee64 
If true specified outputs are recorded to the wallet database and
reloaded at startup.
UnlockCoin() will attempt to erase from db if found in set.
Including bitcoin PR bitcoin#13160 - Unlock spent outputs.
tecnovert added a commit to particl/particl-core that referenced this pull request Jun 1, 2018
@tecnovert
Add permanent option to lockunspent.
9f1c78d 
If true specified outputs are recorded to the wallet database and
reloaded at startup.
UnlockCoin() will attempt to erase from db if found in set.
Including bitcoin PR bitcoin#13160 - Unlock spent outputs.
@meshcollider
Copy link
Contributor

utACK fd9b3a7

@laanwj laanwj mentioned this pull request Jun 24, 2018
Closed
@laanwj laanwj merged commit fd9b3a7 into bitcoin:master Jun 24, 2018
laanwj added a commit that referenced this pull request Jun 24, 2018
@laanwj
Merge #13160: wallet: Unlock spent outputs
868cf43 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes #12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
@Bushstar Bushstar mentioned this pull request Jun 25, 2018
Merged
@random-zebra random-zebra mentioned this pull request Oct 28, 2019
Merged
furszy added a commit to PIVX-Project/PIVX that referenced this pull request Nov 19, 2019
@furszy
Merge #1065: [Wallet] Unlock spent outputs
d605e52 
13f8d5a [Wallet] Unlock spent outputs (random-zebra)

Pull request description:

  Straightforward update backported from bitcoin#13160

  NOTE: the update to wallet_basic functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite).

ACKs for top commit:
  Fuzzbawls:
    utACK 13f8d5a
  furszy:
    utACK 13f8d5a

Tree-SHA512: 2cd585407374a74bfa525b0c690906297a45f73fdc49c97457edd83b95a9bf129c824ceb0c0594b802e3260b0057d5f1577404fb96ed3c0ee0491d433b55aae3
akshaynexus added a commit to dogecash/dogecash-old that referenced this pull request Nov 19, 2019
@akshaynexus
Merge #1065: [Wallet] Unlock spent outputs
f800406 
13f8d5a [Wallet] Unlock spent outputs (random-zebra)

Pull request description:

  Straightforward update backported from bitcoin/bitcoin#13160

  NOTE: the update to wallet_basic functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite).

ACKs for top commit:
  Fuzzbawls:
    utACK 13f8d5a
  furszy:
    utACK 13f8d5a

Tree-SHA512: 2cd585407374a74bfa525b0c690906297a45f73fdc49c97457edd83b95a9bf129c824ceb0c0594b802e3260b0057d5f1577404fb96ed3c0ee0491d433b55aae3
wqking pushed a commit to wqking-temp/Vitae that referenced this pull request May 31, 2020
@furszy @wqking
Merge #1065: [Wallet] Unlock spent outputs
ed01233 
13f8d5aedbcd4e2b1e980555fc95a2619c308094 [Wallet] Unlock spent outputs (random-zebra)

Pull request description:

  Straightforward update backported from bitcoin/bitcoin#13160

  NOTE: the update to wallet_basic functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite).

ACKs for top commit:
  Fuzzbawls:
    utACK 13f8d5aedbcd4e2b1e980555fc95a2619c308094
  furszy:
    utACK 13f8d5a

Tree-SHA512: 2cd585407374a74bfa525b0c690906297a45f73fdc49c97457edd83b95a9bf129c824ceb0c0594b802e3260b0057d5f1577404fb96ed3c0ee0491d433b55aae3
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 2, 2020
@laanwj
Merge #13160: wallet: Unlock spent outputs
388b666 
Summary:
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes #12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605

Backport of Core [[bitcoin/bitcoin#13160 | PR13160]]

Test Plan:
  ninja
  ninja check
  ninja check-functional

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6321
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 7, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#13160: wallet: Unlock spent outputs
4164731 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes bitcoin#12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 7, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#13160: wallet: Unlock spent outputs
a9a0dc6 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes bitcoin#12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#13160: wallet: Unlock spent outputs
719d9a5 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes bitcoin#12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
@buck54321 buck54321 mentioned this pull request Jul 14, 2020
Merged
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Aug 17, 2020
@laanwj @ftrader
Merge #13160: wallet: Unlock spent outputs
5e11f6b 
Summary:
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes #12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605

Backport of Core [[bitcoin/bitcoin#13160 | PR13160]]

Test Plan:
  ninja
  ninja check
  ninja check-functional

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6321
@chappjc chappjc mentioned this pull request Aug 31, 2020
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13160: wallet: Unlock spent outputs
a276a69 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes bitcoin#12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13160: wallet: Unlock spent outputs
6a98d72 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes bitcoin#12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13160: wallet: Unlock spent outputs
21fe14a 
fd9b3a7 test: Output should be unlocked when spent (João Barbosa)
54c3bb4 wallet: Unlock spent outputs (João Barbosa)

Pull request description:

  Fixes bitcoin#12738.

Tree-SHA512: 2c1694727aea0c658d07566c7d11d7afe91218053f84d568fac97413348fa5a977243d6cdeebd1c6550816489e35cb3a31667c8354d9b350de99f979d641d605
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
RPC/REST/ZMQ Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot unlock already spent output
4 participants
@promag @laanwj @maflcko @meshcollider