send dialog / address book interaction unclear #1384

Closed
dooglus opened this Issue May 24, 2012 · 10 comments

Projects

None yet

4 participants

Contributor
dooglus commented May 24, 2012

I just accidentally sent coins to the wrong address due to a misunderstanding of how the client works. I think there are a couple of usability issues which contributed to this happening, as well as my own carelessness.

What I did:

  • go to the 'send' tab
  • paste an address into the 'pay to' box. the 'label' automatically was filled in, confirming that I typed the right address
  • clicked the first icon to the right of the 'pay to' box to see the address book
  • looked to see if the address was in there. it wasn't. clicked 'ok' to dismiss the dialog
  • back at the 'send' tab, the label field was still showing the right value, so I didn't notice that the 'ok' in the previous step had changed the 'pay to' field
  • typed an amount and hit 'send'.

The amount ended up going to the first address in my address book, not to the address with the label that was displayed when I clicked 'send'.

Two comments:

  • when the address book is first opened up, I'd prefer if no address was selected, rather than the first (no label) address. I hadn't selected an address, so thought that 'ok' would leave everything unchanged.
  • when I click 'ok' in the address book causing an address to be copied to the 'pay to' box of the 'send' tab, update the 'label' field (or lack of label) accordingly. currently it leaves the label field unchanged which is misleading. I checked the label field before hitting send, and it was still showing the label I wanted to send to. But the address had been changed, and that is where the funds went.
Owner
laanwj commented May 24, 2012

Oops :/ Apologies for the inconvenience.

Agreed with your suggestions. Updating the label as well was the original behavior of ok, but the code for that has been changed around a "few" times (#1092, #858, #1080, #840) so it might be a regression. It is really hard to keep up with peoples expectations with the current form format.

Maybe it would be better if the label and address were shown as one visual entity, for example email-ish label [address] instead of two separate fields. This would prevent confusion as to what the label refers to (#1168) and problems like this, as the entire field is replaced at once.

The "Ok" button on the address book would be better to be explicit "Choose Address" when eh, choosing addresses.

Contributor
dooglus commented May 24, 2012

I think having an address selected by default isn't ideal. If I click the address book icon then click 'ok' without selecting an address I would like it to leave the 'to' field unchanged.

Luckily the address I sent the coins to was an old instawallet address of mine that I happened to have kept the URL for, so I didn't lose anything.

Owner
laanwj commented May 24, 2012

Agreed.

Phew...

Contributor
burger2 commented Jun 12, 2012

I can confirm this bug in 0.6.2, This only happens when an address has "(no label)" in the address book.

Contributor
burger2 commented Jun 12, 2012

There is an other unclear feature.

  • choose an address with label from the address book
  • change the label in the send tab
  • choose the same address again from the address book

Now it won't change the label back to the one from the address book.

Owner
laanwj commented Jun 12, 2012

@burger2 My idea with #1361 was a proposal to make make it more clear what happens by grouping label/address together visually, but it was shot down very quickly.

I'd still like to somehow put label and address in one field, to make it more clear that they belong together, and that it's nonsensical to change one without the other.

People get confused about this all the time. The current behavior is not a bug, but a result from differing expectations (see also the issues I mention in the first comment).

@laanwj laanwj added a commit to laanwj/bitcoin that referenced this issue Jun 12, 2012
@laanwj laanwj Do not select first address automatically in the address book
This contributed to an accidental send (#1384), and has no clear advantage, better to disable it.
2842fe4
@luke-jr luke-jr added a commit to luke-jr/bitcoin that referenced this issue Jun 17, 2012
@laanwj @luke-jr laanwj + luke-jr Do not select first address automatically in the address book
This contributed to an accidental send (#1384), and has no clear advantage, better to disable it.
b825e81
@coblee coblee pushed a commit to litecoin-project/litecoin that referenced this issue Jul 17, 2012
@laanwj laanwj Do not select first address automatically in the address book
This contributed to an accidental send (#1384), and has no clear advantage, better to disable it.
de02795
@TripleSpeeder TripleSpeeder added a commit to TripleSpeeder/bitcoin that referenced this issue Jul 30, 2012
@TripleSpeeder TripleSpeeder Merge tag 'tags/v0.6.3' into merge_v0.6.3
Version 0.6.3

This is a bug-fix release, with no new features.

CHANGE SUMMARY
==============

Fixed a serious denial-of-service attack that could cause the
bitcoin process to become unresponsive. Thanks to Sergio Lerner
for finding and responsibly reporting the problem. (CVE-2012-3789)

Optimized the process of checking transaction signatures, to
speed up processing of new block messages and make propagating
blocks across the network faster.

Fixed an obscure bug that could cause the bitcoin process to get
stuck on an invalid block-chain, if the invalid chain was
hundreds of blocks long.

Bitcoin-Qt no longer automatically selects the first address
in the address book (Issue #1384).

Fixed minimize-to-dock behavior of Bitcon-Qt on the Mac.

Added a block checkpoint at block 185,333 to speed up initial
blockchain download.

Conflicts:
	src/main.cpp
e2c5be3
Diapolo commented Sep 23, 2012

Is this still an issue?

Contributor
burger2 commented Sep 23, 2012

Yes. As if you click ok in the addresses and the bitcoin address don't have an label then only the bitcoin address will be copied to the send dialog and the label field still has the old text.

The label field in the send dialog should be empty if the bitcoin address don't have an label in address book.

Owner
laanwj commented Sep 24, 2012

As I said in my first reply on this issue, we've tried all the simple fixes to this. No matter what, there will always be someone complaining that the behavior is unintuitive, should be different, etc. In the end, it comes down to taste and individual habit, and we cannot take that into account for everyone.

As I've also said before "People get confused about this all the time. The current behavior is not a bug, but a result from differing expectations".

What you are proposing would bring back issue #840.

The most dangerous problem, selecting the first address book entry automatically, was resolved. So unless someone has a great and very clear idea for reorganizing address/label entry that doesn't confuse anyone, we can close this issue.

@laanwj laanwj closed this Sep 24, 2012
Contributor
burger2 commented Sep 24, 2012

But issue #840 don't have nothing to do with the address book. It was when you typed in a label and then pasted (ctrl+v in windows) in the bitcoin address field, then the label got deleted.

I think @dooglus should comment on this issue.

And the fix about not selecting automatically when address book was opened is very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment