Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename and command line encoding issue on Windows #13869

Closed
ken2812221 opened this issue Aug 3, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@ken2812221
Copy link
Member

commented Aug 3, 2018

This issue tracks the TODO list in order to fix the encoding issue on Window.

Currently Bitcoin Core uses the ANSI encoding on Windows so that it would affected by user's language settings, they might not able to open some non-ASCII name files.

You can test all these changes in #13787 (includes leveldb changes)

Open PRs:

  • Package the Windows installer in unicode mode (NSIS 3+) (#13827, Up for grab, or wait for Ubuntu 20.04 gitian builder host)

Merged PRs:

  • Create the startup shortcut file in unicode mode (#13734)
  • Make filelock work on unicode filename (#13862)
  • Use _wfopen instead of fopen on Windows to pass unicode filename (#13866)
  • Make boost fs::path .string() to be always encoded to utf-8 (#13877)
  • Wrap ifstream and ofstream to accept unicode filename. (#13878)
  • Get the command line arguments using unicode (#13883)
  • Make bdb read the filename using utf-8 (#13884)
  • Make runCommand works on unicode filename (#13886)
  • Convert all (...)A function to (...)W on Windows if it is related to filename or command line. (#13888)
  • Convert boost filesystem error messages from local multibyte to utf-8 (#14192)
  • Make leveldb read the filename using utf-8 (bitcoin-core/leveldb#18)

@ken2812221 ken2812221 changed the title Encoding issue on Windows Filenam encoding issue on Windows Aug 3, 2018

@ken2812221 ken2812221 changed the title Filenam encoding issue on Windows Filename encoding issue on Windows Aug 3, 2018

@fanquake fanquake added the Windows label Aug 4, 2018

@fanquake fanquake added this to the 0.18.0 milestone Aug 4, 2018

@ken2812221 ken2812221 changed the title Filename encoding issue on Windows Filename and command line encoding issue on Windows Aug 6, 2018

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

@sipsorcery @NicolasDorier Mind take a look at this?

@NicolasDorier

This comment has been minimized.

Copy link
Member

commented Aug 31, 2018

Amazing work, ye.

laanwj added a commit to bitcoin-core/leveldb that referenced this issue Jan 26, 2019

Merge #18: Use utf-8 to decode filename
f8e797a Use utf-8 to decode filename (Chun Kuan Lee)

Pull request description:

  See bitcoin/bitcoin#13869

  Enable unicode support for leveldb on Windows

  CI result for applying this change is available in bitcoin/bitcoin#13787

Tree-SHA512: 860261f973ec7aec8d3051632be8154d87854df8a604ef10b9171701f132c4ba9855ca97fc6e2d529ba322a8100e1e160d5d0f2afe558158bde89979815b5246

@ken2812221 ken2812221 closed this Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.