New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin client 0.17.0 ignores wallet's name (file) #14523
Comments
I think I'm able to reproduce this. It looks like #11862 might be causing your wallet config argument to be ignored. Do you see this warning?
We might need to clarify release notes, but this isn't true. You can only specify full paths to wallet directories not wallet files. (Originally this was possible, but it was deemed too dangerous because it might mislead people into creating incomplete backups of wallets). |
@ryanofsky , hi
it's same |
but why i need (or not) to specity test section inside a config? i.e. i already specified a |
Before #11862 and 0.17.0, you didn't need to have I think this is a mistake, and we should backport a fix that will restore the old behavior. It don't think it is ok to just start ignoring settings that used to work. We should probably keep the log message to encourage people to use network-specific sections and be more explicit about settings that are sensitive to which network is used, but we should not just be dropping the settings on the floor. It also seems like a mistake to me that |
Moving to 0.17.2 |
Made it an error instead of warning in #15629, so at least Bitcoin Core wouldn't start with such a config file. |
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
Should be "fixed" in master |
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
…s ignored fae38c3 doc: Fix all typos reported by codespell (MarcoFalke) fa9058f doc: Add release notes for 15629 (MarcoFalke) fa4a922 qa: Add test for missing testnet section in conf file (MarcoFalke) dddd6f0 init: Throw error when network specific config is ignored (MarcoFalke) Pull request description: This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error. Issues: * bitcoin client 0.17.0 ignores wallet's name (file) bitcoin#14523 * Can't set custom rpcport on testnet bitcoin#13777 * ... ACKs for commit fae38c: Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
Old config (version 0.15 and 0.16.0/0.16.3):
It worked pretty nice.
UPD: it does not worked in version 0.17.0 ! BTC client made a new
wallet.dat
fileOn version 0.17.0 i read what i can use full pathes to wallet files.
FAILS. It created
wallet.dat
in/path/to/wallet/
folderFAILS. It created
wallet.dat
in~/.bitcoin/wallets
folder.Current config:
AND i renamed
mywallet.dat
intowallet.dat
to let client work.I run
bitcoin core client 0.17.0
onLinux 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux
.The text was updated successfully, but these errors were encountered: