Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Windows build docs are missing `make deploy` #14699

Closed
ch4ot1c opened this issue Nov 9, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@ch4ot1c
Copy link
Contributor

commented Nov 9, 2018

When building for Windows (using doc/build-windows.md), I discovered the following steps were necessary but undocumented, in order to generate the installer:

sudo apt install nsis
make deploy
makensis share/setup.nsi
@LucianaMarques

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2018

Hi there, I'd like to work on this. Is there any PR on this already?

@fanquake

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

@LucianaMarques no, feel free to make the changes and open one.

@LucianaMarques

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2018

@fanquake pull request opened! thanks

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

The last step is not necessary see my comment here: #14744 (comment)

MarcoFalke added a commit that referenced this issue Dec 18, 2018

Merge #14950: docs: add NSIS setup/install steps to windows docs
82687b5 docs: add NSIS setup/install steps to windows docs (luciana)

Pull request description:

  Supersedes #14744
  Fixes: #14699

  Rearranged the changes in #14744 to be more similar to the macOS docs.

Tree-SHA512: d68f952eee1a97702d23a02e4f35b66dedd3bf104b8ea05de9a642a596c476c40aa76fae5b00a1600b3758e25621226d89216885ec8f52acf89d6eb117421f9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.