New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault running master on NetBSD #17379
Comments
This is an eternal source of problems. I wonder if we can get rid of all locale dependency at some point and just ignore the locale. Probably not as long as we use |
Setting aside the bitcoin/test/lint/lint-locale-dependence.sh Lines 5 to 20 in e204dc1
Perhaps a "good first issue" could be created to tackle the list above? Some of them are really low hanging fruits suitable for new contributors. |
I'm all for replacing those, but none of those functions crashes on having a wrong locale configured, that's very much a boost thing. |
FYI, after progress on #21485, bitcoind on SmartOS (Illumos) suffers from the same issue.
|
@fanquake do you need help testing those changes on SmartOS? I can try to compile your branch. |
fdd7144 system: skip trying to set the locale on NetBSD (fanquake) Pull request description: Just treat it the same as the other BSDs. Fixes #17379. ACKs for top commit: laanwj: Code review ACK fdd7144 practicalswift: cr ACK fdd7144 Tree-SHA512: 5fe0a66f014279ad2683b548692a36af493377fb92d1f28b15dc4feef871190fe08ef40dcc4f5ba21a525fe365c42fb429fe4be0673a1e96db163af587c23204
fdd7144 system: skip trying to set the locale on NetBSD (fanquake) Pull request description: Just treat it the same as the other BSDs. Fixes bitcoin#17379. ACKs for top commit: laanwj: Code review ACK fdd7144 practicalswift: cr ACK fdd7144 Tree-SHA512: 5fe0a66f014279ad2683b548692a36af493377fb92d1f28b15dc4feef871190fe08ef40dcc4f5ba21a525fe365c42fb429fe4be0673a1e96db163af587c23204
Just treat it the same as the other BSDs. Fixes bitcoin#17379. Github-Pull: bitcoin#22390 Rebased-From: fdd7144
Just treat it the same as the other BSDs. Fixes bitcoin#17379. Github-Pull: bitcoin#22390 Rebased-From: fdd7144
Just treat it the same as the other BSDs. Fixes bitcoin#17379. Github-Pull: bitcoin#22390 Rebased-From: fdd7144
Just treat it the same as the other BSDs. Fixes bitcoin#17379. Github-Pull: bitcoin#22390 Rebased-From: fdd7144
Just treat it the same as the other BSDs. Fixes bitcoin#17379. Github-Pull: bitcoin#22390 Rebased-From: fdd7144
fdd7144 system: skip trying to set the locale on NetBSD (fanquake) Pull request description: Just treat it the same as the other BSDs. Fixes bitcoin#17379. ACKs for top commit: laanwj: Code review ACK fdd7144 practicalswift: cr ACK fdd7144 Tree-SHA512: 5fe0a66f014279ad2683b548692a36af493377fb92d1f28b15dc4feef871190fe08ef40dcc4f5ba21a525fe365c42fb429fe4be0673a1e96db163af587c23204
fdd7144 system: skip trying to set the locale on NetBSD (fanquake) Pull request description: Just treat it the same as the other BSDs. Fixes bitcoin#17379. ACKs for top commit: laanwj: Code review ACK fdd7144 practicalswift: cr ACK fdd7144 Tree-SHA512: 5fe0a66f014279ad2683b548692a36af493377fb92d1f28b15dc4feef871190fe08ef40dcc4f5ba21a525fe365c42fb429fe4be0673a1e96db163af587c23204
fdd7144 system: skip trying to set the locale on NetBSD (fanquake) Pull request description: Just treat it the same as the other BSDs. Fixes bitcoin#17379. ACKs for top commit: laanwj: Code review ACK fdd7144 practicalswift: cr ACK fdd7144 Tree-SHA512: 5fe0a66f014279ad2683b548692a36af493377fb92d1f28b15dc4feef871190fe08ef40dcc4f5ba21a525fe365c42fb429fe4be0673a1e96db163af587c23204
While testing 17270 I noticed that master (bdda137) does not run on NetBSD. I assume this started after #17085 changed the fallback locale from
C
toC.UTF-8
. There doesn't seem to be aC.UTF-8
locale on NetBSD.LC_ALL=C src/bitcoind
works,LC_ALL=en_US.UTF-8 src/bitcoind
does not.The text was updated successfully, but these errors were encountered: