Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.20] Fix release tarball #18909

Closed
wants to merge 8 commits into from

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented May 7, 2020

Includes parts of #18556, #18741, #18818, and #18902 needed to fix the release tarball for 0.20

@hebasto
Copy link
Member

hebasto commented May 8, 2020

c474e46:
Mind adding the .sh extension to the make_release_tarball script name to make it available for lint-shell.sh?

@hebasto
Copy link
Member

hebasto commented May 8, 2020

e46e063
Could consider an alternative approach 80190e7 that seems less hacky?

@hebasto
Copy link
Member

hebasto commented May 8, 2020

Concept ACK.

hebasto and others added 8 commits May 14, 2020 04:19
This commit removes the directory that is no longer used since bitcoin#16667.

Github-Pull: bitcoin#18556
Rebased-From: 2aa48ed
Previously, the sourced script would create the source tarball. Now, it
only assigns variables and the source-ing script has more flexibility in
determining what to do with these variables.

See later commit showing how this flexibility is useful in our Guix
builds.

Github-Pull: bitcoin#18741
Rebased-From: 395c113
…elease_tarball

Github-Pull: bitcoin#18818
Rebased-From: 0ea34e7 (partial: gitian only)
… right one

Original-Github-Pull: bitcoin#7522
Rebased-From: e98e3dd e98e3dd

Github-Pull: bitcoin#18902
Rebased-From: d9505bb
@fanquake
Copy link
Member

fanquake commented Apr 8, 2021

I'm going to close this. At this point we're not going to be backporting any tarball related changes to the 0.20 branch. I'll also echo the comments made in #18818; I haven't seen a single complaint/issue related to changes in the 0.20 tarball over the ~10 months since it's been released.

@fanquake fanquake closed this Apr 8, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants