Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: .clang-format compat with clang versions < 9 #19454

Merged
merged 1 commit into from Jul 9, 2020
Merged

tools: .clang-format compat with clang versions < 9 #19454

merged 1 commit into from Jul 9, 2020

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented Jul 6, 2020

Our .clang-format settings inadvertently lost compatibility with Clang versions < 9 in #19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from #19095 (comment).

@jonatack jonatack mentioned this pull request Jul 6, 2020
Merged
@maflcko
Copy link
Member

maflcko commented Jul 6, 2020

Approach ACK b9253c7 , haven't tested

@fanquake fanquake merged commit 6b48c30 into bitcoin:master Jul 9, 2020
@jonatack jonatack deleted the clang-6-compatibility branch July 9, 2020 12:00
@fanquake
Copy link
Member

fanquake commented Jul 9, 2020

cc @jnewbery

@jnewbery
Copy link
Contributor

jnewbery commented Jul 9, 2020

Untested ACK. Compatibility with our stated dependencies is more important than style considerations.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 9, 2020
@fanquake
Merge bitcoin#19454: tools: .clang-format compat with clang version…
843b646 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
5a86247 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
bccbdaa 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
385afae 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
2c1db7b 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
50bb5c9 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
8271531 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#19454: tools: .clang-format compat with clang version…
ee75279 
…s < 9

b9253c7 tools: clang-format 6 compatibility (Jon Atack)

Pull request description:

  Our `.clang-format` settings inadvertently lost compatibility with Clang versions < 9 in bitcoin#19095, including for Debian stable. This patch returns compatibility in the interim until the distros update. See discussion from bitcoin#19095 (comment).

ACKs for top commit:
  MarcoFalke:
    Approach ACK b9253c7 , haven't tested

Tree-SHA512: 4af541a195f48d84ffb80e23aaefb624c66bc78f087c8d92b4af5a654420b69fedf25272c6e4fde2688ff88412d306b7a990ce1e15d8b24180374c625a253fb6
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Scripts and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonatack @maflcko @fanquake @jnewbery