Stable/backport 0.7.2 release plan #2021

Closed
luke-jr opened this Issue Nov 16, 2012 · 14 comments

5 participants

@luke-jr
Bitcoin member

Continuing from #2009...

New fixes in master since previous list (@gavinandresen Are these OK to backport now as well?):

  • 90841fd (#1984) VariantClear@4 + shutdown@8 patch
  • 4ade04d (#2012) Print error for coinbase-pays-too-much case of ConnectBlock failing

@Diapolo 6b3783a does change strings, but only the English in them, not the meaning, so the old translations are direct 1:1 mapping.

@gavinandresen If the NACKs are debatable (if not, just say so), I'd like to clarify whether the memset one is a (minor) security fix or not?

@gavinandresen
Bitcoin member

Those two are fine.

memset change is too many lines of code changes for essentially zero net security benefit (if the attacker can read your bitcoin process' memory then you're already toast).

@luke-jr
Bitcoin member

#2022 looks like a good idea to throw into this too.

@Diapolo

@luke-jr 6b3783a Is fine with me then, your explanation did it's job ;). Just wondering, if the legacy translations will still be used then? I have new translation files ready in another pull now btw.

@luke-jr
Bitcoin member

@Diapolo Gavin NACK'd 6b3783a anyway, so it won't be in 0.7.2. Maybe 0.7.3 :) I've pulled in translations of strings that were missing for 0.7.1, if that's what you mean by the second part.

@luke-jr
Bitcoin member

Should we wait for #1927?

@Diapolo

@luke-jr I would vote no, as this is just a small glitch but not really a heavy UX problem IMHO. I would much more love to see #2024 get in 0.7.2.

@laanwj
Bitcoin member

Agreed with Diapolo. #2024 is a fix for a boost issue which makes boost::path unsafe to use in global constuctors on windows. This can cause a crash at shutdown. #1927 is 'nice to have' category but no need to wait for it.

@luke-jr
Bitcoin member

Backported #2024, added release notes (+ bumped versions), and tagged v0.7.2rc1.

@sipa
Bitcoin member

ACK on the diff between v0.7.1 and 0dba651 (v0.7.2rc1). I can't build myself right now, unfortunately.

I didn't look at the changed translations closely.

@luke-jr
Bitcoin member

v0.7.2rc2 is tagged, if anyone else can contribute gitian builds...

@gavinandresen
Bitcoin member

tagged at gitorious?

It is confusing and error-prone to be using github for issues and major releases, but gitorious for a seemingly random collection of stuff.

@laanwj laanwj closed this Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment