Repository navigation
BIP324 tracking issue #27634
Description
Activity
- pinned this issue
on May 26, 2023 - added a commit that references this issue
on Jul 12, 2023 - added a commit that references this issue
on Jul 17, 2023 - added a commit that references this issue
on Aug 10, 2023 Review comments from #28008 that could be incorporated into future changes:
Reacted by Sebastian Falbesoner, Pieter Wuille and stratospher- added a commit that references this issue
on Aug 24, 2023 - added a commit that references this issue
on Sep 8, 2023 @sipa Want to add an item for mentioning BIP324 in https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md?
@real-or-random Done in #28331.
Reacted by Tim Ruffing- added a commit that references this issue
on Oct 3, 2023 Minor thing that was missed, can be included in some of the followups:
s/TransportDeserializer/Transport class/
diff --git i/src/net.cpp w/src/net.cpp index 6b2ef5f43d..5b0efc16aa 100644 --- i/src/net.cpp +++ w/src/net.cpp @@ -812,13 +812,13 @@ const uint256& V1Transport::GetMessageHash() const CNetMessage V1Transport::GetReceivedMessage(const std::chrono::microseconds time, bool& reject_message) { AssertLockNotHeld(m_recv_mutex); // Initialize out parameter reject_message = false; - // decompose a single CNetMessage from the TransportDeserializer + // decompose a single CNetMessage from the Transport class LOCK(m_recv_mutex); CNetMessage msg(std::move(vRecv)); // store message type string, time, and sizes msg.m_type = hdr.GetCommand(); msg.m_time = time; @@ -3724,13 +3724,13 @@ void CNode::MarkReceivedMsgsForProcessing() { AssertLockNotHeld(m_msg_process_queue_mutex); size_t nSizeAdded = 0; for (const auto& msg : vRecvMsg) { // vRecvMsg contains only completed CNetMessage - // the single possible partially deserialized message are held by TransportDeserializer + // the single possible partially deserialized message are held by Transport class nSizeAdded += msg.m_raw_message_size; } LOCK(m_msg_process_queue_mutex); m_msg_process_queue.splice(m_msg_process_queue.end(), vRecvMsg); m_msg_process_queue_size += nSizeAdded;
- unpinned this issue
on Oct 5, 2023 - added a commit that references this issue
on Jan 31, 2024 There are a few minor follow-ups to consider still, but I believe this issue can be closed. Thanks everyone for getting us this far!
Reacted by 0xf0xx0 and Ján SáreníkReacted by 0xf0xx0Reacted by 0xf0xx0, Tim Ruffing and Ján Sáreník- locked and limited conversation to collaborators
on Sep 23, 2025
This issue will be updated to reflect the current state of BIP324 integration.
PRs ready for review:
Overall plan:
CNodeobjects on reconnect: BIP324 integration #28331 (comment)V2Transportfor everything, dropping abstract class: BIP324 integration #28331 (comment)Older stuff:
Prehistory:
Superseded: