Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can anyone tell me what is ACK and utACK means? #6100

Closed
micromaomao opened this issue May 3, 2015 · 2 comments
Closed

Can anyone tell me what is ACK and utACK means? #6100

micromaomao opened this issue May 3, 2015 · 2 comments

Comments

@micromaomao
Copy link

In some, or lots of, pull request, people say ACK, can anyone tell me what this meaning?

@fanquake
Copy link
Member

fanquake commented May 3, 2015

See the notes in doc/developer-notes.md

Concept ACK - Agree with the idea and overall direction, but haven't reviewed the code changes or tested them.

utACK (untested ACK) - Reviewed and agree with the code changes but haven't actually tested them.

Tested ACK - Reviewed the code changes and have verified the functionality or bug fix.

ACK - A loose ACK can be confusing. It's best to avoid them unless it's a documentation/comment only change in which case there is nothing to test/verify; therefore the tested/untested distinction is not there.

NACK - Disagree with the code changes/concept. Should be accompanied by an explanation.

@micromaomao
Copy link
Author

Thank!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants