/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bitcoin GUI is not built when only qt4 is installed #7189

Closed
MarcoFalke opened this Issue Dec 9, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
Build system GUI
Projects
None yet
Milestone
No milestone
3 participants
@MarcoFalke @jonasschnelli @laanwj
@MarcoFalke
Member

MarcoFalke commented Dec 9, 2015

From IRC:

@phantomcircuit: @jonasschnelli, ./configure doesn't detect qt4 on my debian jessie system
i had to manually specify --with-gui=qt4
@MarcoFalke
Member

MarcoFalke commented Dec 9, 2015

We switched to qt5 by default (#6938) and don't fall back to qt4, it seems.
@jonasschnelli
Member

jonasschnelli commented Dec 9, 2015

I tend to feel that this is the correct behavior. We kind of deprecated Qt4 and it might lead to graphical issues. Qt5 is the environment that allows us to compete with other GUI apps.

IMO a manual -with-gui=qt4 in case of missing qt5 is okay because it makes user aware that they don't use the recommended dependencies.

@laanwj laanwj added the Build system label Dec 9, 2015

@laanwj
Owner

laanwj commented Dec 9, 2015

I agree that Qt4 is on its way out, but this was not the intention.

I've only changed the default, not the fallback mechanism. It could be that something broke there though. I'm not really good with autotools. @theuni can you take a look?

This was referenced Feb 11, 2016

Closed
Closed

dooglus added a commit to dooglus/bitcoin that referenced this issue Feb 26, 2016

@dooglus
Remove spurious dollar sign. Fixes #7189.
3d19193

@dooglus dooglus referenced this issue Feb 26, 2016

Merged

build: Remove spurious dollar sign. Fixes #7189. #7604

@laanwj laanwj closed this in #7604 Feb 29, 2016

laanwj added a commit that referenced this issue Feb 29, 2016

@laanwj
Merge #7604: build: Remove spurious dollar sign. Fixes #7189. 
3d19193 Remove spurious dollar sign. Fixes #7189. (Chris Moore)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
354b03d

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this issue Apr 27, 2016

@dooglus @MarcoFalke
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
1c3d38b

laanwj added a commit that referenced this issue Jun 9, 2016

@laanwj
Merge #7938: [0.12.2] Backports 
c3d1bc3 CBase58Data::SetString: cleanse the full vector (Kaz Wesley)
43c14ac Fix headers announcements edge case (Suhas Daftuar)
06c73a1 Removed call to `TryCreateDirectory` from `GetDefaultDataDir` in `src/util.cpp`. (Alexander Regueiro)
7e71785 Use txid as key in mapAlreadyAskedFor (Suhas Daftuar)
5583a3d Add curl to Gitian setup instrustions (BtcDrak)
d3ead9b Avoid "Unknown command" messages when receiving getaddr on outbound connections. (R E Broadley)
a5bc6a1 Remove vfReachable and modify IsReachable to only use vfLimited. (Patrick Strateman)
52c1011 Clarify description of blockindex (Matthew Zipkin)
21b2f82 Don't resend wallet txs that aren't in our own mempool (Alex Morcos)
66d5408 Fix memleak in TorController [rework] (Wladimir J. van der Laan)
1c3d38b Remove spurious dollar sign. Fixes #7189. (Chris Moore)
64fd0ce fix spelling of advertise in src and doc (jloughry)
a9e73f7 Fix and cleanup listreceivedbyX documentation (instagibbs)
9095594 Do not download transactions during inital sync (ptschip)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
20d00a1

zander added a commit to zander/bitcoinclassic that referenced this issue Jun 16, 2016

@dooglus @zander
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
6181dc4

@MarcoFalke MarcoFalke added the GUI label Jun 25, 2016

thokon00 added a commit to faircoin/faircoin that referenced this issue Jun 28, 2016

@dooglus @thokon00
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
1af0ea8

nomnombtc added a commit to nomnombtc/bitcoin that referenced this issue Nov 12, 2016

@dooglus @nomnombtc
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
ceb3caa

nomnombtc added a commit to nomnombtc/bitcoin that referenced this issue Nov 12, 2016

@dooglus @nomnombtc
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
bd7e68e

nomnombtc added a commit to nomnombtc/bitcoin that referenced this issue Nov 13, 2016

@dooglus @nomnombtc
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
0b47488

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this issue Nov 14, 2016

@dooglus @sickpig
Remove spurious dollar sign. Fixes #7189. 
Github-Pull: #7189
Rebased-From: 3d19193
This commit was signed with a verified signature.
@sickpig sickpig Andrea Suisani
GPG key ID: A9CA1D0EE3789741 Learn about signing commits
733d6f1

rebroad pushed a commit to rebroad/bitcoin that referenced this issue Dec 7, 2016

@dooglus @dgenr8
Remove spurious dollar sign. Fixes #7189.
964070a

protonn added a commit to argentumproject/argentum that referenced this issue Apr 11, 2017

@dooglus @protonn
Remove spurious dollar sign. Fixes #7189.
e30d8d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment