Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis shutdown didn't result in failed job #8103

Closed
sdaftuar opened this issue May 26, 2016 · 3 comments
Closed

Travis shutdown didn't result in failed job #8103

sdaftuar opened this issue May 26, 2016 · 3 comments

Comments

@sdaftuar
Copy link
Member

#8049 had a bug that would cause some RPC tests to fail, but travis didn't catch it, because the machine was shutdown(!):

https://travis-ci.org/bitcoin/bitcoin/jobs/129694378

Test 122: PASS [581]
Test 123: PASS [581]
Test 124: PASS [582]
Test 125: PASS [582]
Stopping nodes
Cleaning up
Tests successful

Pass: True, Duration: 37 s
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................�
Broadcast message from root@testing-gce-017e1b04-0cfc-4a39-9cf0-a92f5dae8c5d
    (unknown) at 16:47 ...
The system is going down for power off NOW!
........

Seems like it's worth investigating what happened here, and if its possible to make sure that jobs will be marked as failed when something like this happens?

Separately, I think we can also improve the rpc test framework to fail quicker and more obviously in this particular situation; I'll PR something soon.

@maflcko
Copy link
Member

maflcko commented May 26, 2016

Wow, thanks for noticing! I have marked this issue with 'upstream', as this should be handled by travis?

@maflcko
Copy link
Member

maflcko commented May 26, 2016

Counting the number of dots indicates that the previous test passed 10 minutes before the shutdown. Travis fails after 10 minutes of empty stdout/stderr, but it should not shut down...

@theuni
Copy link
Member

theuni commented May 26, 2016

Looks like this was a one-off upstream error: travis-ci/travis-ci#4924 (comment)

@maflcko maflcko closed this as completed May 27, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants