Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nolisten=1 no longer works in bitcoin.conf #846

Closed
dooglus opened this issue Feb 16, 2012 · 2 comments
Closed

nolisten=1 no longer works in bitcoin.conf #846

dooglus opened this issue Feb 16, 2012 · 2 comments

Comments

@dooglus
Copy link
Contributor

@dooglus dooglus commented Feb 16, 2012

From the forum annoucement:

The -nolisten, -noupnp and -nodnsseed command-line
options were renamed to -listen, -upnp and -dnsseed,
with a default value of 1. The old names are still
supported for compatibility

but that's only true on the command line, not for bitcoin.conf options.

I have a bitcoin.conf with "nolisten=1" in it, but it's being ignored.

The "interpret -nofoo as -foo=0 (and -nofoo=0 as -foo=1, as long as -foo not set)" code is in util.cpp's ParseParameters() function and runs before the bitcoin.conf file is even read.

This breaks existing configuration files, so it's probably best to fix this before the release of 0.6.

dooglus added a commit to dooglus/bitcoin that referenced this issue Feb 16, 2012
dooglus added a commit to dooglus/bitcoin that referenced this issue Feb 16, 2012
@dooglus

This comment has been minimized.

Copy link
Contributor Author

@dooglus dooglus commented Feb 16, 2012

I should probably draw attention to the change I made to the comment too. I think the closing paren was in the wrong place before:

  •    //  interpret -nofoo as -foo=0 (and -nofoo=0 as -foo=1, as long as -foo not set)
    
  •    // interpret -nofoo as -foo=0 (and -nofoo=0 as -foo=1) as long as -foo not set
    
@sipa

This comment has been minimized.

Copy link
Member

@sipa sipa commented Feb 19, 2012

Fixed in #852.

@sipa sipa closed this Feb 19, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this issue Jul 17, 2012
destenson pushed a commit to destenson/bitcoin--bitcoin that referenced this issue Jun 26, 2016
* Remove nTime from IsCollateralValid and document function
ptschip added a commit to ptschip/bitcoin that referenced this issue Jan 11, 2018
ptschip added a commit to ptschip/bitcoin that referenced this issue Jan 11, 2018
ptschip pushed a commit to ptschip/bitcoin that referenced this issue Jan 11, 2018
Fix for bitcoin#846: remove extra space between year and month in debug ui.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.