New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet passphrase timeout of several years doesn't work #922

Closed
gavinandresen opened this Issue Mar 9, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@gavinandresen
Contributor

gavinandresen commented Mar 9, 2012

I've got an encrypted wallet and want to unlock it "until next reboot."

So I tried setting a timeout of 10 years (315360000 seconds):

bitcoind walletpassphrase "wouldn't you like to know" 315360000

... but when I check the unlocked_until time it is unlocked only until the end of the month :

bitcoind getinfo  
"unlocked_until" : 1333159764,

1333159764 is 2012-03-31 02:09:24 GMT

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 10, 2012

Member

ne of my recent bugfixes changes an internal timer from seconds to milliseconds. The time you report seems to be 1000 times shorter in the future than expected. I'll have a look at it tomorrow.

Member

sipa commented Mar 10, 2012

ne of my recent bugfixes changes an internal timer from seconds to milliseconds. The time you report seems to be 1000 times shorter in the future than expected. I'll have a look at it tomorrow.

sipa added a commit that referenced this issue Mar 12, 2012

Merge pull request #926 from gmaxwell/master
Resolves issue #922 - "wallet passphrase timeout of several years doesn't work"

coblee pushed a commit to litecoin-project/litecoin that referenced this issue Jul 17, 2012

Resolves issue bitcoin#922 - "wallet passphrase timeout of several ye…
…ars doesn't work"

2^31 milliseconds is only about 25 days. Also clamps Sleep() to 10 years,
because it currently sleeps for 0 seconds when the sleep time would cross
2^31 seconds since the epoch. Hopefully boost will be fixed by 2028.

coblee pushed a commit to litecoin-project/litecoin that referenced this issue Jul 17, 2012

Merge pull request bitcoin#926 from gmaxwell/master
Resolves issue bitcoin#922 - "wallet passphrase timeout of several years doesn't work"

suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this issue Dec 5, 2017

Merge bitcoin#922: Refactor/fix spork
42bdf42 Refactor/fix spork:
- move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager
- move Sign, CheckSignature, Relay to CSporkMessage
- move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks
- rename SporkKey to SporkPubKey
- bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully
- few log format changes, cleaned up includes

ptschip pushed a commit to ptschip/bitcoin that referenced this issue Jan 19, 2018

Merge pull request bitcoin#922 from sickpig/fix-warnings
Initialize pindexNewTip at declaration time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment