test_bitcoin fails valgrind #9278

Open
TheBlueMatt opened this Issue Dec 5, 2016 · 2 comments

Comments

Projects
None yet
5 participants
Contributor

TheBlueMatt commented Dec 5, 2016

On recent master, test_bitcoin generates new valgrind warnings, specifically, rpc_tests.cpp:91 calls getnetworkinfo(), which, on rpc/net.cpp:437 looks up the connman's nLocalServices, which were never initialized (normally this would happen with CConnman::Start).

@theuni might want to take a look here.

laanwj added the Tests label Dec 5, 2016

theuni was assigned by jonasschnelli Dec 5, 2016

Member

theuni commented Dec 6, 2016

Thanks. This really needs an Init() that the ctor and Start both call.

Will fix.

MarcoFalke added this to the 0.14.0 milestone Dec 6, 2016

@MarcoFalke MarcoFalke modified the milestone: 0.15.0, 0.14.0 Jan 27, 2017

Contributor

achow101 commented Jul 14, 2017

This is still a problem. Any fixes yet? @theuni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment