Uninstaller should have option to remove data (except for wallet) #993

Open
gavinandresen opened this Issue Mar 26, 2012 · 7 comments

Comments

Projects
None yet
5 participants
@gavinandresen
Contributor

gavinandresen commented Mar 26, 2012

Install and then run Bitcoin-Qt.
Then quit and uninstall.

RESULT: C:\Program Files\Bitcoin\locale folder is left behind.
RESULT: %APPDATA%\Bitcoin\addr.dat, .lock, db.log, debug.log, etc left behind

I'd expect everything except wallet.dat to be removed (and it would be nice if there was an uninstall checkbox, NOT checked by default, to remove the wallet, too).

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 26, 2012

Member

IMO, anything that removes wallet.dat should probably send a decrypted-from-user encrypted-to-developers copy to some server. Otherwise, I can see people misreading the checkbox label and destroying coins all too easily...

Member

luke-jr commented Mar 26, 2012

IMO, anything that removes wallet.dat should probably send a decrypted-from-user encrypted-to-developers copy to some server. Otherwise, I can see people misreading the checkbox label and destroying coins all too easily...

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 26, 2012

Member

I have no clue where the locale/ directory comes from. Could be a Qt issue, but it's not being created on linux, and I don't remember seeing it before when running my own windows compiles... probably a remnant from the Wx UI which had locales in a separate directory

Member

laanwj commented Mar 26, 2012

I have no clue where the locale/ directory comes from. Could be a Qt issue, but it's not being created on linux, and I don't remember seeing it before when running my own windows compiles... probably a remnant from the Wx UI which had locales in a separate directory

@gavinandresen

This comment has been minimized.

Show comment
Hide comment
@gavinandresen

gavinandresen Mar 26, 2012

Contributor

Thanks @laanwj; I'll test some more, and if it is a Wx bitcoin remnant I'll have the 0.6 installer remove it, too.

Contributor

gavinandresen commented Mar 26, 2012

Thanks @laanwj; I'll test some more, and if it is a Wx bitcoin remnant I'll have the 0.6 installer remove it, too.

@gavinandresen

This comment has been minimized.

Show comment
Hide comment
@gavinandresen

gavinandresen Mar 28, 2012

Contributor

Fixed in 0.6rc5.

EDIT: re-opened, only partially fixed, it should still remove everything except for wallet.dat and bitcoin.conf from %APPDATA%\Bitcoin

Contributor

gavinandresen commented Mar 28, 2012

Fixed in 0.6rc5.

EDIT: re-opened, only partially fixed, it should still remove everything except for wallet.dat and bitcoin.conf from %APPDATA%\Bitcoin

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Mar 28, 2012

Member

careful— removing the db logs when bitcoin was shutdown uncleanly may make the wallet unreadable.

Member

gmaxwell commented Mar 28, 2012

careful— removing the db logs when bitcoin was shutdown uncleanly may make the wallet unreadable.

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Sep 21, 2012

Is there still work to be done here? I simply can't tell as I never use the installer.

Diapolo commented Sep 21, 2012

Is there still work to be done here? I simply can't tell as I never use the installer.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 24, 2014

Member

An option to the uninstaller to remove data (except for the wallet) would make sense. However, this should not be the default behavior because people may want to uninstall one version to install another (for example remove a 32-bit version to install the 64-bit one).

Member

laanwj commented Feb 24, 2014

An option to the uninstaller to remove data (except for the wallet) would make sense. However, this should not be the default behavior because people may want to uninstall one version to install another (for example remove a 32-bit version to install the 64-bit one).

@laanwj laanwj changed the title from Windows uninstall leaves locale\ directory, %APPDATA\Bitcoin\... to Uninstaller should have option to remove data (except for wallet) Apr 23, 2014

@laanwj laanwj added Improvement and removed Bug labels Apr 23, 2014

suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this issue Dec 5, 2017

Bug fixes for the governance rpc interface (#993)
* Bug fixes for the governance rpc interface
 - Allow use of the gobject getvotes command
 - Fix order of arguments to CGovernanceVote constructor

* Added getvotes to gobject help message and fixed parameter name in the
error/usage message.

ptschip pushed a commit to ptschip/bitcoin that referenced this issue Mar 15, 2018

Clear warn in QT and getinfo if initial conditions is not valid anymo…
…re (#993)

If a previous warning about unknown version in more than 50% of the last
100 mined blocks has been dispatched, but the conditions for such
warning are not met anymore, just clear all the venues where this warn
is displayed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment