Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init README format to render correctly on github #10036

Merged
merged 1 commit into from Apr 2, 2017

Conversation

@jlopp
Copy link
Contributor

commented Mar 19, 2017

Just need some preformatted tags to fix the github rendering.

@fanquake fanquake added the Docs label Mar 19, 2017

@fanquake

This comment has been minimized.

Copy link
Member

commented Mar 19, 2017

In future, please just force push changes to an existing PR rather than open a new one.

@jlopp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2017

Changes are the same as the other PR; I didn't know that you could change the base target via github UI.

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2017

Hmm, I do not understand why we have both doc/init.md and contrib/init/README.md. And why do they share the list of files in contrib/init? And why OS X's plist is not in the list in doc/init.md.

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 20, 2017

Documentation in doc/init.md is for users.

The README.md in the directory is meant as a description of that directory, and why it exists. It could (but does not currently) point to the documentation.

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2017

But the change itself is OK ;-)

@fanquake

This comment has been minimized.

Copy link
Member

commented Mar 22, 2017

trivial ACK b99fbad

@laanwj laanwj merged commit b99fbad into bitcoin:master Apr 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Apr 2, 2017
Merge #10036: Fix init README format to render correctly on github
b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 20, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 20, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 20, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 21, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 22, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 22, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 22, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 22, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 23, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
UdjinM6 added a commit to UdjinM6/dash that referenced this pull request May 23, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 23, 2019
Merge bitcoin#10036: Fix init README format to render correctly on gi…
…thub

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.