Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Rename first named arg of createrawtransaction #10084

Merged
merged 1 commit into from Mar 29, 2017

Conversation

@MarcoFalke
Copy link
Member

commented Mar 26, 2017

Fixes #10079.

@dcousens
Copy link
Contributor

left a comment

ACK

@NicolasDorier

This comment has been minimized.

Copy link
Member

commented Mar 26, 2017

utACK

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

utACK fa55853. Makes sense. As this is an API change, this needs mention in the release notes.

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

ACK fa55853

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Mar 27, 2017
@TheBlueMatt

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2017

Hmm, I suppose it's unlikely anyone is even using named args in 0.14 yet, so probably fine, but as folks start using this we should prefer to update docs over code.

utACK fa55853

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

Hmm, I suppose it's unlikely anyone is even using named args in 0.14 yet, so probably fine, but as folks start using this we should prefer to update docs over code.

In general you are right, but in this specific case 'inputs' is a much better name for the argument. I think this slipped by in review of #8811.

@laanwj laanwj merged commit fa55853 into bitcoin:master Mar 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Mar 29, 2017
Merge #10084: rpc: Rename first named arg of createrawtransaction
fa55853 rpc: Rename first named arg of createrawtransaction (MarcoFalke)

Tree-SHA512: f2e07183f2503344e676e08fe0fd73e995d7c6fda3fc11c64116208dec8e445f0627583dfba85014129b6f2dc7e253b9d760e57e66811272db89e9ba25ce6dbc

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1703-createRawName branch Mar 29, 2017

codablock added a commit to codablock/dash that referenced this pull request Jan 26, 2018
Merge bitcoin#10084: rpc: Rename first named arg of createrawtransaction
fa55853 rpc: Rename first named arg of createrawtransaction (MarcoFalke)

Tree-SHA512: f2e07183f2503344e676e08fe0fd73e995d7c6fda3fc11c64116208dec8e445f0627583dfba85014129b6f2dc7e253b9d760e57e66811272db89e9ba25ce6dbc
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#10084: rpc: Rename first named arg of createrawtransaction
fa55853 rpc: Rename first named arg of createrawtransaction (MarcoFalke)

Tree-SHA512: f2e07183f2503344e676e08fe0fd73e995d7c6fda3fc11c64116208dec8e445f0627583dfba85014129b6f2dc7e253b9d760e57e66811272db89e9ba25ce6dbc
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
Merge bitcoin#10084: rpc: Rename first named arg of createrawtransaction
fa55853 rpc: Rename first named arg of createrawtransaction (MarcoFalke)

Tree-SHA512: f2e07183f2503344e676e08fe0fd73e995d7c6fda3fc11c64116208dec8e445f0627583dfba85014129b6f2dc7e253b9d760e57e66811272db89e9ba25ce6dbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.