New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Rename unused submitblock argument as 'dummy' #10191

Merged
merged 1 commit into from Jun 24, 2017

Conversation

Projects
None yet
6 participants
@jnewbery
Member

jnewbery commented Apr 11, 2017

Dead code, not used since the submitblock RPC was introduced in #1691 5 years ago.

EDIT: This PR now renames the unused arguments in submitblock and prioritisetransaction

@jnewbery jnewbery closed this Apr 11, 2017

@jnewbery jnewbery reopened this Apr 12, 2017

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Apr 12, 2017

Member

I assume thar argument exists for compliance with BIP 22?

Member

sipa commented Apr 12, 2017

I assume thar argument exists for compliance with BIP 22?

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Apr 19, 2017

Member

Indeed. We could perhaps trim down on the docs (since Core doesn't use it), but including the object shouldn't be made to error.

Member

luke-jr commented Apr 19, 2017

Indeed. We could perhaps trim down on the docs (since Core doesn't use it), but including the object shouldn't be made to error.

@jnewbery

This comment has been minimized.

Show comment
Hide comment
@jnewbery

jnewbery Apr 19, 2017

Member

ok, pushed new version:

  • help text is removed
  • sending a 'parameters' object does not cause an error, but is ignored.
Member

jnewbery commented Apr 19, 2017

ok, pushed new version:

  • help text is removed
  • sending a 'parameters' object does not cause an error, but is ignored.
Show outdated Hide outdated src/rpc/mining.cpp Outdated

@jnewbery jnewbery changed the title from [trivial] Remove unused submit block parameters argument to [trivial] Rename unused RPC arguments 'dummy' Jun 6, 2017

@jnewbery

This comment has been minimized.

Show comment
Hide comment
@jnewbery

jnewbery Jun 6, 2017

Member

I've cherry-picked @TheBlueMatt's commit from #10488 into this PR since they're doing similar things. This PR now renames the unused arguments in prioritisetransaction and submitblock to dummy.

Member

jnewbery commented Jun 6, 2017

I've cherry-picked @TheBlueMatt's commit from #10488 into this PR since they're doing similar things. This PR now renames the unused arguments in prioritisetransaction and submitblock to dummy.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 14, 2017

Member

This went in through #10488, IIRC? Anything left to do here?

Member

laanwj commented Jun 14, 2017

This went in through #10488, IIRC? Anything left to do here?

@jnewbery

This comment has been minimized.

Show comment
Hide comment
@jnewbery

jnewbery Jun 14, 2017

Member

#10488 renamed the unused parameter in prioritisetransaction to dummy. This does the same for submitblock.

(I cherry-picked the commit from #10488 into here because they were doing the same thing for two different RPCs so I thought it made sense to combine them into a single PR. Now that #10488 is merged I've rebased this onto master so this PR only affects submitblock).

Member

jnewbery commented Jun 14, 2017

#10488 renamed the unused parameter in prioritisetransaction to dummy. This does the same for submitblock.

(I cherry-picked the commit from #10488 into here because they were doing the same thing for two different RPCs so I thought it made sense to combine them into a single PR. Now that #10488 is merged I've rebased this onto master so this PR only affects submitblock).

@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Jun 19, 2017

Contributor

utACK 0ef7de9

Contributor

TheBlueMatt commented Jun 19, 2017

utACK 0ef7de9

@laanwj laanwj merged commit 0ef7de9 into bitcoin:master Jun 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 24, 2017

Merge #10191: [trivial] Rename unused RPC arguments 'dummy'
0ef7de9 [RPCs] Remove submitblock parameters argument help text (John Newbery)

Tree-SHA512: f39ad4bb3006e3d722fa51ae2ab4a48726e740993d6bed5737b355d1e0a99cf475ca9519f97adf8cde1b7187b14a24d5951ce4f34624d01d9ef84b49124c2894

@jnewbery jnewbery changed the title from [trivial] Rename unused RPC arguments 'dummy' to [trivial] Rename unused submitblock argument as 'dummy' Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment