Switch chainstate db and cache to per-txout model #10195

sipa · Apr 12, 2017

Since Bitcoin Core v0.8, we've used a per-tx model for the chainstate database and its cache. This means that the database is effectively a map from txids to the list of unspent outputs for that transaction. This PR changes that to a map from outpoints ((txid,index) pairs) to just the individual unspent output for that outpoint.

The original reason for aggregating the outputs per transaction was to save space: this way, we could avoid duplicating the txid and transaction meta across the multiple outputs. However, LevelDB internally uses an encoding that omits repeated prefix bytes in keys, and because of that, duplicating the txids is not very significant.

There are many advantages for using a per-txout model:

Simpler code.
Avoiding the CPU overhead of deserializing and serializing the unused outputs.
More predictable memory usage.
More easily adaptable to various cache flushing strategies.

Downsides:

Slightly larger on-disk representation, and sometimes larger in-memory representation (when there are multiple outputs for the same txid in the cache, which becomes optional).

This PR includes:

The main commit from #10248. We'll be dropping tx nVersion from the undo data later, so reserializing data from disk won't roundtrip anymore. This change allows us to compute the checksum based on the written data rather than the reserialized data.
#10249, as we'll be using some c++11 methods of std::unordered_map which aren't available in all versions of boost::unordered_map.
#10250, as the new tests trigger the problem fixed there.
A forward-compatible undo data format change (new versions can use old undo data, not the other way around).
Switch to a new per-txout coinsview model with related database changes.
Upgrade code to convert the old chainstate to a new chainstate (which is interruptible).
Adapted unit and functional tests (thanks to @ryanofsky for adapting the unit tests).

Tests:

All existing unit and functional tests pass.
Manually verified that continuing a reindex started with old code succeeds (even when recovering from a crash in the middle of flushing while upgrading).

Commit links:

Preparation:

e66dbde: Add SizeEstimate to CDBBatch
f54580e: error() in disconnect for disk corruption, not inconsistency
e484652: Introduce CHashVerifier to hash read data
7e00322: Add specialization of SipHash for 256 + 32 bit data
d342424: Remove/ignore tx version in utxo and undo
c3aa0c1: Report on-disk size in gettxoutsetinfo
7d991b5: Store/allow tx metadata in all undo records

Switch to COutPoint/Coin instead of uint256/CCoins:

422634e: Introduce Coin, a single unspent output
cb2c7fd: Replace CTxInUndo with Coin
bd83111: Optimization: Coin&& to ApplyTxInUndo
0003911: Introduce new per-txout CCoinsViewCache functions
f68cdfe: Switch from per-tx to per-txout CCoinsViewCache methods in some places
c87b957: Only pass things committed to by tx's witness hash to CScriptCheck
8b3868c: Switch CScriptCheck to use Coin instead of CCoins
961e483: Switch tests from ModifyCoins to AddCoin/SpendCoin
05293f3: Remove ModifyCoins/ModifyNewCoins
13870b5: Replace CCoins-based CTxMemPool::pruneSpent with isSpent
4ec0d9e: Refactor GetUTXOStats in preparation for per-COutPoint iteration
5083079: Switch CCoinsView and chainstate db from per-txid to per-txout

Cleanup:

ce23efa: Extend coins_tests
97072d6: Remove unused CCoins methods
41aa5b7: Pack Coin more tightly
b2af357: Reduce reserved memory space for flushing
8b25d2c: Upgrade from per-tx database to per-txout
580b023: [MOVEONLY] Move old CCoins class to txdb.cpp
119e552: Merge CCoinsViewCache's GetOutputFor and AccessCoin
73de2c1: Rename CCoinsCacheEntry::coins to coin
a5e02bc: Increase travis unit test timeout
5898279: scripted-diff: various renames for per-utxo consistency

This is awesome.

gmaxwell · Apr 12, 2017

This is awesome.

Rebased on top of new #10148.

sipa · Apr 16, 2017

Rebased on top of new #10148.

Rebased without #10148 at popular request.

sipa · Apr 19, 2017

Rebased without #10148 at popular request.

Few overrides needed probably:

+./coins.h:200:10: warning: 'BatchWrite' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+    bool BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock);
+         ^
+./coins.h:178:18: note: overridden virtual function is here
+    virtual bool BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock);
+                 ^
+./coins.h:201:23: warning: 'Cursor' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+    CCoinsViewCursor *Cursor() const;
+                      ^
+./coins.h:181:31: note: overridden virtual function is here
+    virtual CCoinsViewCursor *Cursor() const;
+                              ^
+2 warnings generated.

And few initializations:

+./undo.h:70:23: note: initialize the variable 'count' to silence this warning
+        uint64_t count;
+                      ^
+                       = 0
...
+./coins.h:81:22: note: initialize the variable 'code' to silence this warning
+        uint32_t code;
+                     ^
+                      = 0

paveljanik · Apr 19, 2017

Few overrides needed probably:

+./coins.h:200:10: warning: 'BatchWrite' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+    bool BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock);
+         ^
+./coins.h:178:18: note: overridden virtual function is here
+    virtual bool BatchWrite(CCoinsMap &mapCoins, const uint256 &hashBlock);
+                 ^
+./coins.h:201:23: warning: 'Cursor' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+    CCoinsViewCursor *Cursor() const;
+                      ^
+./coins.h:181:31: note: overridden virtual function is here
+    virtual CCoinsViewCursor *Cursor() const;
+                              ^
+2 warnings generated.

And few initializations:

+./undo.h:70:23: note: initialize the variable 'count' to silence this warning
+        uint64_t count;
+                      ^
+                       = 0
...
+./coins.h:81:22: note: initialize the variable 'code' to silence this warning
+        uint32_t code;
+                     ^
+                      = 0

TheBlueMatt · Apr 20, 2017

TheBlueMatt reviewed Apr 20, 2017

View changes

Concept ACK. Briefly looked over most of the commits except the big one, which I only briefly skimmed, but am left wondering if there's an easier way to get that +650-881 commit in. At least the first 6 commits could be merged separately (I know the first two are already in another PR), but I'm not sure thats sufficient. Anyway, will circle back around to doing a full review as other things get merged.

test/functional/blockchain.py

src/txdb.cpp

I'm splitting the commits up more. I've pushed one update already, but I'm working splitting the big commit further.

sipa · Apr 22, 2017

I'm splitting the commits up more. I've pushed one update already, but I'm working splitting the big commit further.

Done. There is still one commit that does many things at once ("Switch CCoinsView and chainstate db to per-txout"), but splitting it is nontrivial. If requested, I can try splitting the database format change into a second commit, but that would require adding a bunch of conversion logic in the first commit that just gets removed in the second one. Thoughts?

sipa · Apr 24, 2017

Done. There is still one commit that does many things at once ("Switch CCoinsView and chainstate db to per-txout"), but splitting it is nontrivial. If requested, I can try splitting the database format change into a second commit, but that would require adding a bunch of conversion logic in the first commit that just gets removed in the second one. Thoughts?

paveljanik · Apr 25, 2017

paveljanik reviewed Apr 25, 2017

View changes

src/undo.h

Rebased and reset the author timestamps (so that GitHub shows them in logical order, $@#!*).

sipa · Apr 25, 2017

Rebased and reset the author timestamps (so that GitHub shows them in logical order, $@#!*).

Rebased.

sipa · May 3, 2017

Rebased.

ryanofsky · May 3, 2017

ryanofsky reviewed May 3, 2017

View changes

utACK 493f03f. This is a really nice change, and seems complete and ready to go as far as I could tell. I left a lot of comments and possible suggestions in my review, but they're all very minor, so feel free ignore anything not of interest.

src/validation.cpp

src/hash.h

src/rpc/blockchain.cpp

src/coins.h

src/net_processing.cpp

ryanofsky · May 3, 2017

src/rpc/blockchain.cpp

+        ss << *(const CScriptBase*)(&output.second.out.scriptPubKey);
+        ss << VARINT(output.second.out.nValue);
+        stats.nTransactionOutputs++;
+        stats.nTotalAmount += output.second.out.nValue;


In commit "Refactor GetUTXOStats in preparation for per-COutPoint iteration":

This stats.ntotalamount value seems to get overwritten in line 815. Probably that line should be removed.

src/rpc/rawtransaction.cpp

src/txmempool.cpp

@ryanofsky

Updated and addressed many of @ryanofsky's review comments. I'll respond only individually to the ones I'm not addressing.

sipa · May 4, 2017

Updated and addressed many of @ryanofsky's review comments. I'll respond only individually to the ones I'm not addressing.

Here is a graph of the speed and memory usage of a -reindex-chainstate until the default assumevalid point, with infinity -dbcache, on a 2.2GHz dual-cpu 28-core 56-threads machine with 256GiB RAM. Note that the x axis is progress (so proportional to the number of transactions).

sipa · May 5, 2017

Here is a graph of the speed and memory usage of a -reindex-chainstate until the default assumevalid point, with infinity -dbcache, on a 2.2GHz dual-cpu 28-core 56-threads machine with 256GiB RAM. Note that the x axis is progress (so proportional to the number of transactions).

jnewbery · May 5, 2017

jnewbery reviewed May 5, 2017

View changes

I've reviewed up to 4f09ae5 "Introduce new per-txout CCoinsViewCache functions" and have a few nits. I'll finish reviewing next week.

src/coins.h

src/undo.h

src/coins.h

Same machine, but flushing at 1300 MiB:

sipa · May 6, 2017

Same machine, but flushing at 1300 MiB:

theuni · May 9, 2017

theuni reviewed May 9, 2017

View changes

src/coins.cpp

I've pushed a few more changes (rewriting the commits, but not a rebase), renaming some of the classes and variables to be more consistent.

For any further changes I'll create fixup commits in order to not hurt review.

sipa · May 10, 2017

I've pushed a few more changes (rewriting the commits, but not a rebase), renaming some of the classes and variables to be more consistent.

For any further changes I'll create fixup commits in order to not hurt review.

utACK 37b2735. Thanks for implementing so many review suggestions. Removing coins->Clear() from ApplyTxInUndo in an earlier commit, renaming CCoin to Coin, changing stats.nSerializedSize were the only significant changes since my last review that I don't remember seeing suggested, and these all look good.

ryanofsky · May 10, 2017

utACK 37b2735. Thanks for implementing so many review suggestions. Removing coins->Clear() from ApplyTxInUndo in an earlier commit, renaming CCoin to Coin, changing stats.nSerializedSize were the only significant changes since my last review that I don't remember seeing suggested, and these all look good.

sdaftuar · May 12, 2017

sdaftuar reviewed May 12, 2017

View changes

I've spent a bunch of time code reviewing today; got up to 21791e4.

Posting my current set of comments now; will pick review up again on Monday.

src/undo.h

src/coins.cpp

src/txmempool.h

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/txmempool.cpp

TheBlueMatt · May 12, 2017

TheBlueMatt reviewed May 12, 2017

View changes

Got through a big chunk, but still a bunch to review.

src/undo.h

src/validation.cpp

src/coins.cpp

src/coins.h

src/init.cpp

src/net_processing.cpp

src/rpc/blockchain.cpp

src/txdb.h

Squashed history with fixups. Original history:

83367a9 Add SizeEstimate to CDBBatch
ac6910b error() in disconnect for disk corruption, not inconsistency
f7beab2 Introduce CHashVerifier to hash read data
e3d9ac3 Add specialization of SipHash for 256 + 32 bit data
5be8c48 Remove/ignore tx version in utxo and undo
ec8c261 Store/allow tx metadata in all undo records
ac70d1f Introduce Coin, a single unspent output
50a8df0 Replace CTxInUndo with Coin
c3ce6c9 Optimization: Coin&& to ApplyTxInUndo
777f4c6 Introduce new per-txout CCoinsViewCache functions
8df47a3 Switch from per-tx to per-txout CCoinsViewCache methods in some places
5466816 Switch CScriptCheck to use Coin instead of CCoins
ce86045 Switch tests from ModifyCoins to AddCoin/SpendCoin
b514426 Remove ModifyCoins/ModifyNewCoins
593a632 Replace CCoins-based CTxMemPool::pruneSpent with isSpent
deb42bb Refactor GetUTXOStats in preparation for per-COutPoint iteration
21791e4 Switch CCoinsView and chainstate db from per-txid to per-txout
6fd519e Remove unused CCoins methods
575ffb3 Pack Coin more tightly
f2cd835 Reduce reserved memory space for flushing
b951db2 Upgrade from per-tx database to per-txout
229b89c [MOVEONLY] Move old CCoins class to txdb.cpp
fdab87c Merge CCoinsViewCache's GetOutputFor and AccessCoin
37b2735 Rename CCoinsCacheEntry::coins to coin
e581f28 f Replace CTxInUndo with Coin: initialize count variale
69f14c4 f Introduce new per-txout CCoinsViewCache functions: add comment explaining fCoinbase
71ccd9d f Switch CCoinsView and chainstate db from per-txid to per-txout: fix txmempool comment
fdfafc5 f Remove/ignore tx version in utxo and undo: remove ill-defined bytes_serialized
9da167e Report on-disk size in gettxoutsetinfo
3e04e32 f Switch CCoinsView and chainstate db from per-txid to per-txout: re-add sanity check in gettxoutproof
c898541 f Switch CCoinsView and chainstate db from per-txid to per-txout: CTxMempool::TrimToSize should not use per-txid logic for pvNoRemainingSpends
b69f3bc f Replace CTxInUndo with Coin: split TxInUndoSerializer off from deserializer
544c34b f Replace CTxInUndo with Coin: don't hardcode max outputs per block
bf4dadb f error() in disconnect for disk corruption, not inconsistency: correct type in extern ApplyTxInUndo in coins_tests.cpp
6ac7ea3 f Optimization: Coin&& to ApplyTxInUndo: Comment that all of txundo.prevout was moved
369afe4 f Introduce new per-txout CCoinsViewCache functions: do not compute CTxOut() size in loop
dc2bb20 f Introduce new per-txout CCoinsViewCache functions: Add comment explaining AddCoins potential_overwrite assumptions
5611b76 f Switch from per-tx to per-txout CCoinsViewCache methods in some places: remove redundant nHeight < 1000000000 logic
51c7c42 f Switch CCoinsView and chainstate db from per-txid to per-txout: add overrides
b5621d6 f Switch CCoinsView and chainstate db from per-txid to per-txout: still try COutPoint(hash, 0) in AlreadyHave
ea2a5b9 Only pass things committed to by tx's witness hash to CScriptCheck

sipa · May 13, 2017

Squashed history with fixups. Original history:

83367a9 Add SizeEstimate to CDBBatch
ac6910b error() in disconnect for disk corruption, not inconsistency
f7beab2 Introduce CHashVerifier to hash read data
e3d9ac3 Add specialization of SipHash for 256 + 32 bit data
5be8c48 Remove/ignore tx version in utxo and undo
ec8c261 Store/allow tx metadata in all undo records
ac70d1f Introduce Coin, a single unspent output
50a8df0 Replace CTxInUndo with Coin
c3ce6c9 Optimization: Coin&& to ApplyTxInUndo
777f4c6 Introduce new per-txout CCoinsViewCache functions
8df47a3 Switch from per-tx to per-txout CCoinsViewCache methods in some places
5466816 Switch CScriptCheck to use Coin instead of CCoins
ce86045 Switch tests from ModifyCoins to AddCoin/SpendCoin
b514426 Remove ModifyCoins/ModifyNewCoins
593a632 Replace CCoins-based CTxMemPool::pruneSpent with isSpent
deb42bb Refactor GetUTXOStats in preparation for per-COutPoint iteration
21791e4 Switch CCoinsView and chainstate db from per-txid to per-txout
6fd519e Remove unused CCoins methods
575ffb3 Pack Coin more tightly
f2cd835 Reduce reserved memory space for flushing
b951db2 Upgrade from per-tx database to per-txout
229b89c [MOVEONLY] Move old CCoins class to txdb.cpp
fdab87c Merge CCoinsViewCache's GetOutputFor and AccessCoin
37b2735 Rename CCoinsCacheEntry::coins to coin
e581f28 f Replace CTxInUndo with Coin: initialize count variale
69f14c4 f Introduce new per-txout CCoinsViewCache functions: add comment explaining fCoinbase
71ccd9d f Switch CCoinsView and chainstate db from per-txid to per-txout: fix txmempool comment
fdfafc5 f Remove/ignore tx version in utxo and undo: remove ill-defined bytes_serialized
9da167e Report on-disk size in gettxoutsetinfo
3e04e32 f Switch CCoinsView and chainstate db from per-txid to per-txout: re-add sanity check in gettxoutproof
c898541 f Switch CCoinsView and chainstate db from per-txid to per-txout: CTxMempool::TrimToSize should not use per-txid logic for pvNoRemainingSpends
b69f3bc f Replace CTxInUndo with Coin: split TxInUndoSerializer off from deserializer
544c34b f Replace CTxInUndo with Coin: don't hardcode max outputs per block
bf4dadb f error() in disconnect for disk corruption, not inconsistency: correct type in extern ApplyTxInUndo in coins_tests.cpp
6ac7ea3 f Optimization: Coin&& to ApplyTxInUndo: Comment that all of txundo.prevout was moved
369afe4 f Introduce new per-txout CCoinsViewCache functions: do not compute CTxOut() size in loop
dc2bb20 f Introduce new per-txout CCoinsViewCache functions: Add comment explaining AddCoins potential_overwrite assumptions
5611b76 f Switch from per-tx to per-txout CCoinsViewCache methods in some places: remove redundant nHeight < 1000000000 logic
51c7c42 f Switch CCoinsView and chainstate db from per-txid to per-txout: add overrides
b5621d6 f Switch CCoinsView and chainstate db from per-txid to per-txout: still try COutPoint(hash, 0) in AlreadyHave
ea2a5b9 Only pass things committed to by tx's witness hash to CScriptCheck

laanwj · May 15, 2017

laanwj reviewed May 15, 2017

View changes

laanwj · May 15, 2017

src/rpc/blockchain.cpp

@@ -878,8 +891,8 @@ UniValue gettxoutsetinfo(const JSONRPCRequest& request)
            "  \"bestblock\": \"hex\",   (string) the best block hash hex\n"
            "  \"transactions\": n,      (numeric) The number of transactions\n"
            "  \"txouts\": n,            (numeric) The number of output transactions\n"
-            "  \"bytes_serialized\": n,  (numeric) The serialized size\n"
            "  \"hash_serialized\": \"hash\",   (string) The serialized hash\n"


doc: hash_serialized_2

the name should be updated to hash_serialized_2. The description should also be updated to say that hash_serialized_2 will not be compatible with hash_serialized from clients <0.15.0.

I've been testing this on a slow system: on an ARM (i.MX6), USB2 external harddisk, the database upgrade took about 50 minutes:

2017-05-15 10:27:45 Upgrading database...
2017-05-15 11:20:25 LoadBlockIndexDB: last block file = 869

Not necessarily in this pull, but some kind of progress feedback like for rescans / reindexes would be indispensable. Users might assume that the client has crashed after no log messages for such a long time.

laanwj · May 15, 2017

I've been testing this on a slow system: on an ARM (i.MX6), USB2 external harddisk, the database upgrade took about 50 minutes:

2017-05-15 10:27:45 Upgrading database...
2017-05-15 11:20:25 LoadBlockIndexDB: last block file = 869

Not necessarily in this pull, but some kind of progress feedback like for rescans / reindexes would be indispensable. Users might assume that the client has crashed after no log messages for such a long time.

morcos · Jun 7, 2017

morcos reviewed Jun 7, 2017

View changes

posthumous utACK (very untested)

nice work.
i left my couple of nits anyway.
I can open a PR to address the output lookups in ATMP and for any of the others that are worth addressing.

src/coins.cpp

morcos · Jun 7, 2017

src/validation.cpp

+                COutPoint out(hash, o);
+                Coin coin;
+                view.SpendCoin(out, &coin);
+                if (tx.vout[o] != coin.out) {


Do we want to check that coin.nHeight == pindex->nHeight ?
Not sure if it matters, but that used to get checked...

morcos · Jun 7, 2017

src/coins.h

-    //! This may (but cannot always) return true for fully spent transactions
-    virtual bool HaveCoins(const uint256 &txid) const;
+    //! Just check whether we have data for a given outpoint.
+    //! This may (but cannot always) return true for spent outputs.


This comment is incorrect I believe? It will never return true (nor should it) for a spent output

src/validation.cpp

morcos · Jun 7, 2017

src/txdb.h

-static constexpr int MAX_BLOCK_COINSDB_USAGE = 200 * DB_PEAK_USAGE_FACTOR;
-//! Always periodic flush if less than this much space still available.
-static constexpr int MIN_BLOCK_COINSDB_USAGE = 50 * DB_PEAK_USAGE_FACTOR;
+static constexpr int MAX_BLOCK_COINSDB_USAGE = 10 * DB_PEAK_USAGE_FACTOR;


maybe this should be 30?
sdaftuar said he saw 17 in only a week of testing

17 was incorrect; I mistakenly reported the cache delta between blocks (which includes the effect of transactions on the cache) as the per-block cache delta.

Earlz · Sep 11, 2017

Earlz reviewed Sep 11, 2017

View changes

Earlz · Sep 11, 2017

src/rest.cpp

    template <typename Stream, typename Operation>
    inline void SerializationOp(Stream& s, Operation ser_action)
    {
-        READWRITE(nTxVer);
+        uint32_t nTxVerDummy = 0;
+        READWRITE(nTxVerDummy);


What is the point of this? Just to keep the database backwards compatible?

jonasschnelli added the UTXO Db and Indexes label Apr 12, 2017

sipa added the Resource usage label Apr 12, 2017

sdaftuar referenced this pull request Apr 19, 2017
Merged
Use non-atomic flushing with block replay #10148

This was referenced Apr 21, 2017

Merged

Rewrite addrdb with less duplication using CHashVerifier #10248

Merged

Switch CCoinsMap from boost to std unordered_map #10249

laanwj added this to Blockers in High-priority for review Apr 27, 2017

sipa referenced this pull request May 14, 2017
Closed
Report LevelDB estimate for chainstate size in gettxoutsetinfo #10396

sipa referenced this pull request Jun 1, 2017
Merged
Replace bytes_serialized with bogosize #10426

This was referenced Jun 2, 2017

Merged

Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... #8498

Merged

scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE #10502

ryanofsky referenced this pull request Jun 2, 2017
Open
CCoinsViewCache code cleanup & deduplication #9384

This was referenced Jun 2, 2017

Merged

Bugfix: missing == 0 after randrange #10514

Merged

Cache full script execution results in addition to signatures #10192

fanquake removed this from Blockers in High-priority for review Jun 7, 2017

morcos referenced this pull request Jun 8, 2017
Merged
Make check to distinguish between orphan txs and old txs more efficient. #10557

sipa deleted the sipa:pertxoutcache branch Jun 23, 2017

jnewbery referenced this pull request Jul 31, 2017
Closed
TODO for release notes 0.15.0 #9889
12 of 12 tasks complete

FelixWeis referenced this pull request Aug 11, 2017
Merged
[RPC] trivial: gettxout no longer shows version of tx #11029

kallewoof referenced this pull request Sep 11, 2017
Closed
Notice of copyright infrigement #85

dangershony referenced this pull request Sep 21, 2017
Open
Bitcoin UTXO db has changed #481

sickpig referenced this pull request Oct 1, 2017
Merged
dbcache phase 3 enhancements #785

codablock referenced this pull request Oct 24, 2017
Merged
Third batch of per-utxo backports (up until 0.15, excluding actual per-utxo) #1697

codablock referenced this pull request Oct 26, 2017
Merged
Backport bitcoin perutxo #1701

ryanofsky referenced this pull request Mar 16, 2018
Merged
Add static_assert to prevent VARINT(<signed value>) #9753

dagurval referenced this pull request May 8, 2018
Merged
Switch chainstate db and cache to per-txout model #420

bitcoin/bitcoin

Join GitHub today

Switch chainstate db and cache to per-txout model #10195

Conversation

sipa commented Apr 12, 2017 • edited

jonasschnelli added the UTXO Db and Indexes label Apr 12, 2017

sipa added the Resource usage label Apr 12, 2017

This comment has been minimized.

gmaxwell commented Apr 12, 2017

This comment has been minimized.

sipa commented Apr 16, 2017

This comment has been minimized.

sipa commented Apr 19, 2017

This comment has been minimized.

paveljanik commented Apr 19, 2017 • edited

sdaftuar referenced this pull request Apr 19, 2017

TheBlueMatt reviewed Apr 20, 2017 View changes

This was referenced Apr 21, 2017

This comment has been minimized.

sipa commented Apr 22, 2017

This comment has been minimized.

sipa commented Apr 24, 2017

paveljanik reviewed Apr 25, 2017 View changes

This comment has been minimized.

sipa commented Apr 25, 2017

laanwj added this to Blockers in High-priority for review Apr 27, 2017

This comment has been minimized.

sipa commented May 3, 2017

ryanofsky reviewed May 3, 2017 View changes

This comment has been minimized.

This comment has been minimized.

sipa commented May 4, 2017

This comment has been minimized.

sipa commented May 5, 2017

jnewbery reviewed May 5, 2017 View changes

This comment has been minimized.

sipa commented May 6, 2017

theuni reviewed May 9, 2017 View changes

This comment has been minimized.

sipa commented May 10, 2017

This comment has been minimized.

ryanofsky commented May 10, 2017

sdaftuar reviewed May 12, 2017 View changes

TheBlueMatt reviewed May 12, 2017 View changes

This comment has been minimized.

sipa commented May 13, 2017

sipa referenced this pull request May 14, 2017

laanwj reviewed May 15, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

laanwj commented May 15, 2017

sipa referenced this pull request Jun 1, 2017

This was referenced Jun 2, 2017

ryanofsky referenced this pull request Jun 2, 2017

This was referenced Jun 2, 2017

fanquake removed this from Blockers in High-priority for review Jun 7, 2017

morcos reviewed Jun 7, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sdaftuar Jun 7, 2017 • edited

morcos referenced this pull request Jun 8, 2017

sipa deleted the sipa:pertxoutcache branch Jun 23, 2017

jnewbery referenced this pull request Jul 31, 2017

FelixWeis referenced this pull request Aug 11, 2017

MarcoFalke added a commit that referenced this pull request Aug 11, 2017

Earlz reviewed Sep 11, 2017 View changes

This comment has been minimized.

kallewoof referenced this pull request Sep 11, 2017

dangershony referenced this pull request Sep 21, 2017

codablock added a commit to codablock/dash that referenced this pull request Sep 27, 2017

sickpig referenced this pull request Oct 1, 2017

codablock added a commit to codablock/dash that referenced this pull request Oct 12, 2017

codablock referenced this pull request Oct 24, 2017

codablock added a commit to codablock/dash that referenced this pull request Oct 26, 2017

codablock added a commit to codablock/dash that referenced this pull request Oct 26, 2017

codablock referenced this pull request Oct 26, 2017

codablock added a commit to codablock/dash that referenced this pull request Oct 30, 2017

sipa commented Apr 12, 2017 •

edited

paveljanik commented Apr 19, 2017 •

edited

TheBlueMatt reviewed Apr 20, 2017

View changes

paveljanik reviewed Apr 25, 2017

View changes

ryanofsky reviewed May 3, 2017

View changes

jnewbery reviewed May 5, 2017

View changes

theuni reviewed May 9, 2017

View changes

sdaftuar reviewed May 12, 2017

View changes

TheBlueMatt reviewed May 12, 2017

View changes

laanwj reviewed May 15, 2017

View changes

morcos reviewed Jun 7, 2017

View changes

sdaftuar Jun 7, 2017 •

edited

Earlz reviewed Sep 11, 2017

View changes