Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Bugfix: PrioritiseTransaction updates the mempool tx counter #10196
Conversation
fanquake
added
the
Mempool
label
Apr 12, 2017
|
utACK 909306c |
|
Test for this? |
|
utACK, good catch |
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Apr 21, 2017
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Apr 21, 2017
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Apr 21, 2017
sdaftuar
added some commits
Apr 3, 2017
|
Rebased (due to conflict in the test) |
|
Anything else needed here? |
| @@ -115,5 +115,16 @@ def run_test(self): | ||
| assert_equal(self.nodes[0].sendrawtransaction(tx_hex), tx_id) | ||
| assert(tx_id in self.nodes[0].getrawmempool()) | ||
| + # Test that calling prioritisetransaction is sufficient to trigger |
paveljanik
May 12, 2017
Contributor
nit: What about some self.log.info call here?
self.log.info("Assert that prioritising transaction changes the block template")
|
tested ACK 6c2e25c Test fails on master, so OK. |
|
utACK 6c2e25c |
sipa
merged commit 6c2e25c
into
bitcoin:master
May 17, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
added a commit
that referenced
this pull request
May 17, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to nomnombtc/bitcoin
that referenced
this pull request
Jul 17, 2017
added a commit
to nomnombtc/bitcoin
that referenced
this pull request
Jul 17, 2017
added a commit
to runn1ng/bitcoin
that referenced
this pull request
Oct 30, 2017
added a commit
to runn1ng/bitcoin
that referenced
this pull request
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sdaftuar commentedApr 12, 2017
The mempool's nTransactionsUpdated is used by getblocktemplate
to trigger new invocations of CreateNewBlock().